-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-ec2): VPC construct - make Internet Gateway creation fully controllable #26270
Closed
1 of 2 tasks
Labels
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Comments
Obirah
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 6, 2023
github-actions
bot
added
the
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
label
Jul 6, 2023
Obirah
changed the title
aws-ec2: VPC construct - make Internet Gateway creation fully controllable
(aws-ec2): VPC construct - make Internet Gateway creation fully controllable
Jul 6, 2023
peterwoodworth
added
p2
effort/small
Small work item – less than a day of effort
needs-review
good first issue
Related to contributions. See CONTRIBUTING.md
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 6, 2023
Thanks for the FR, makes sense 👍🏻 |
related to aws/aws-cdk-rfcs#507 and #5927 |
Thanks, I was looking for that pahud |
mergify bot
pushed a commit
that referenced
this issue
Jul 12, 2023
The `createInternetGateway` allows disabling the creation of a default internet gateway for VPSs with non-isolated subnets. Closes #26270. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
bmoffatt
pushed a commit
to bmoffatt/aws-cdk
that referenced
this issue
Jul 29, 2023
The `createInternetGateway` allows disabling the creation of a default internet gateway for VPSs with non-isolated subnets. Closes aws#26270. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
effort/small
Small work item – less than a day of effort
feature-request
A feature should be added or improved.
good first issue
Related to contributions. See CONTRIBUTING.md
p2
Describe the feature
Currently the
Vpc
construct contains logic that determines whether to create an internet gateway here.There should be a feature that allows to control the creation of the internet gateway explicitly.
Use Case
I'm deploying VPCs in an enterprise environment that requires to create the VPC only with private subnets of the CDK type
PRIVATE_WITH_EGRESS
because our subnets are connected to a transit gateway and hence are not to be consideredPRIVATE_ISOLATED
- this is important for dynamic lookups, e.g. for EKS.My Vpc looks like this:
The subnet configuration like that:
This setup results in an unwanted internet gateway being created. Of course, there's a simple workaround that I use:
Proposed Solution
There should be a
createInternetGateway
flag in theVpcProps
that explicitly allows me to disable the creation of an internet gateway that precedes over the above mentioned computation in order to provide a clean convention-over-configuration approach.Other Information
No response
Acknowledgements
CDK version used
2.85.0
Environment details (OS name and version, etc.)
any
The text was updated successfully, but these errors were encountered: