Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-stepfunctions-tasks: Tag Batch Jobs #26336

Closed
2 tasks
gael-ft opened this issue Jul 12, 2023 · 2 comments · Fixed by #26349
Closed
2 tasks

aws-stepfunctions-tasks: Tag Batch Jobs #26336

gael-ft opened this issue Jul 12, 2023 · 2 comments · Fixed by #26349
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@gael-ft
Copy link

gael-ft commented Jul 12, 2023

Describe the feature

Currently there's no way to tag a Batch job with BatchSubmitJob construct properties.
But looks like it's supported using AWS Console.

Use Case

Categorize / manage resources used, here Batch jobs.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.74.0 (build 70e2a33)

Environment details (OS name and version, etc.)

MacOS
@gael-ft gael-ft added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2023
@peterwoodworth
Copy link
Contributor

Thanks for the feature request,

We'll need to add this as a prop, and then pass it in here

aws-cdk/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/batch/submit-job.ts

Line 231 in 9fca790

return {

I'm marking this as a p2, which means the team won't be able to get to this soon. Check out the contributing guide if you'd like to help by submitting a pull request for this feature.

@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 12, 2023
@lpizzinidev lpizzinidev mentioned this issue Jul 13, 2023
Merged
lpizzinidev added a commit to lpizzinidev/aws-cdk that referenced this issue Jul 25, 2023
@lpizzinidev
Merge branch 'main' into awsgh-26336
b9dbecd
mergify bot added a commit to lpizzinidev/aws-cdk that referenced this issue Jul 25, 2023
@mergify
Merge branch 'main' into awsgh-26336
e464650
@mergify mergify bot closed this as completed in #26349 Jul 25, 2023
mergify bot pushed a commit that referenced this issue Jul 25, 2023
@lpizzinidev
fix(stepfunctions-tasks): specify tags in BatchSubmitJob properties (#…
f24ece1 
…26349)

This change adds the possibility to specify the [`tags`](https://docs.aws.amazon.com/batch/latest/APIReference/API_SubmitJob.html#:~:text=Required%3A%20No-,tags,-The%20tags%20that) property in the `BatchSubmitJob` construct.

Closes #26336.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@lpizzinidev @bmoffatt
fix(stepfunctions-tasks): specify tags in BatchSubmitJob properties (a…
45c1156 
…ws#26349)

This change adds the possibility to specify the [`tags`](https://docs.aws.amazon.com/batch/latest/APIReference/API_SubmitJob.html#:~:text=Required%3A%20No-,tags,-The%20tags%20that) property in the `BatchSubmitJob` construct.

Closes aws#26336.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(stepfunctions-tasks): specify tags in BatchSubmitJob properties lpizzinidev/aws-cdk
2 participants
@gael-ft @peterwoodworth