Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-ecs: Incorrect Partition Names For Disabling ECS Alarms #26456

Closed
bmoor-amzn opened this issue Jul 20, 2023 · 2 comments · Fixed by #26458
Closed

aws-ecs: Incorrect Partition Names For Disabling ECS Alarms #26456

bmoor-amzn opened this issue Jul 20, 2023 · 2 comments · Fixed by #26458
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1

Comments

@bmoor-amzn
Copy link

Describe the bug

A recent change was released to add support for ECS alarms. The partitions listed here are NOT the correct partition names.

They should be aws-iso and aws-iso-b

Expected Behavior

No Alarm property should be added on a service in aws-iso and aws-iso-b regions.

Current Behavior

The Alarm property is added to a service in aws-iso and aws-iso-b regions. These cause cloud formation deployments to fail.

Reproduction Steps

  1. Create an ECS service for a stack in us-isob-east-1
  2. Observe Alarm property exists

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.87.0 (build 9fca790)

Framework Version

No response

Node.js Version

18

OS

linux

Language

Java

Language Version

No response

Other information

No response
@bmoor-amzn bmoor-amzn added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2023
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Jul 20, 2023
@bvtujo bvtujo mentioned this issue Jul 20, 2023
Merged
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Jul 20, 2023
@peterwoodworth
Copy link
Contributor

Thanks for reporting, and thanks @bvtujo for getting a PR up so quickly

@mergify mergify bot closed this as completed in #26458 Jul 21, 2023
mergify bot pushed a commit that referenced this issue Jul 21, 2023
@bvtujo
fix(ecs): deployment alarm configurations are being added in isolated…
eea223b 
… partitions (#26458)

Fixes #26456. 

Renames the isolated partitions to their correct names. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@bvtujo @bmoffatt
fix(ecs): deployment alarm configurations are being added in isolated…
dad54a4 
… partitions (aws#26458)

Fixes aws#26456. 

Renames the isolated partitions to their correct names. 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container bug This issue is a bug. effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ecs): deployment alarm configurations are being added in isolated partitions bvtujo/aws-cdk
2 participants
@peterwoodworth @bmoor-amzn