Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(logs): Configure subscription filter name on l2 #26485

Closed
2 tasks
peterwoodworth opened this issue Jul 24, 2023 · 1 comment · Fixed by #26498
Closed
2 tasks

(logs): Configure subscription filter name on l2 #26485

peterwoodworth opened this issue Jul 24, 2023 · 1 comment · Fixed by #26498
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@peterwoodworth
Copy link
Contributor

Describe the feature

Would like to set the subscription filter name as a prop on the L2 https://docs.aws.amazon.com/cdk/api/v2/docs/aws-cdk-lib.aws_logs.SubscriptionFilter.html

Use Case

To set a specific name without requiring escape hatches

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

mac
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort labels Jul 24, 2023
@tam0ri tam0ri mentioned this issue Jul 25, 2023
Merged
@mergify mergify bot closed this as completed in #26498 Jul 27, 2023
mergify bot pushed a commit that referenced this issue Jul 27, 2023
@tam0ri
feat(logs): configure custom subscription filter name (#26498)
7ddb305 
Currently, we can't set the subscription filter name as a prop for L2 SubscriptionFilter construct. This PR introduces the new prop `filterName`. This will let us set a specific name without requiring escape hatches.

Closes #26485

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Aug 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(logs): configure custom subscription filter name tam0ri/aws-cdk
1 participant
@peterwoodworth