Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awseks: Unable to update EKS cluster tags #26614

Closed
ytizhang opened this issue Aug 2, 2023 · 3 comments
Closed

awseks: Unable to update EKS cluster tags #26614

ytizhang opened this issue Aug 2, 2023 · 3 comments
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/medium Medium work item – several days of effort p2

Comments

@ytizhang
Copy link

ytizhang commented Aug 2, 2023

Describe the bug

We are using awscdk Go version v2.63.2 to create cluster with tags. When we create a cluster, the tags are correctly added. However, when we update a cluster, the tags on EKS cluster is not updated.
CDK diff shows
[] Custom::AWSCDK-EKS-Cluster EKSCluster/Resource/Resource EKSClusterE11008B6
└─ [
] Config
└─ [~] .tags:
├─ [+] Added: .LastRevalidatedAt
└─ [+] Added: .LastRevalidatedBy

Tried using the latest version v2.89.0, and saw the same issue

Expected Behavior

The tags on EKS cluster should be updated

Current Behavior

The tags on EKS cluster doesn't get updated

Reproduction Steps

Part of the Go code that's used to create a cluster:

tags := getClusterTags(props) // get tags from our internal cluster type
clusterProps := &awseks.ClusterProps{
                 ...
		Tags:                 &tags,
                 ...
	}
cluster := awseks.NewCluster(stack, jsii.String("EKSCluster"), clusterProps)

We have an internal cluster type definition which we can specify the tags to use.

Reproduction steps:

  1. Run cdk deploy... to create a cluster with tags.
  2. Update the cluster type to add some additional tags
  3. Run cdk deploy... to update the cluster
  4. Observed the cluster tags are not updated.

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.89.0

Framework Version

No response

Node.js Version

v18.12.1

OS

MacOS

Language

Go

Language Version

1.18

Other information

No response

@ytizhang ytizhang added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 2, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 2, 2023
@pahud
Copy link
Contributor

pahud commented Aug 2, 2023

Thanks for report. Closing in favor of #26614

@pahud pahud closed this as completed Aug 2, 2023
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 2, 2023
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@ytizhang
Copy link
Author

ytizhang commented Aug 2, 2023

@pahud I guess you put the wrong link in your closing comment. Please check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service bug This issue is a bug. effort/medium Medium work item – several days of effort p2
Projects
None yet
Development

No branches or pull requests

2 participants