Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aws-eks: Add properties from IHelmChartOptions to HelmChart construct #26678

Closed
1 of 2 tasks
pergardebrink opened this issue Aug 9, 2023 · 3 comments · Fixed by #26852
Closed
1 of 2 tasks

aws-eks: Add properties from IHelmChartOptions to HelmChart construct #26678

pergardebrink opened this issue Aug 9, 2023 · 3 comments · Fixed by #26852
Assignees
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@pergardebrink
Copy link

Describe the feature

I would like the helm chart properties (at least: chart, repository, version) to be available in the HelmChart construct after instantiation.

Use Case

I was looking at writing an aspect that I wanted to use to inspect all helm charts added in our CDK stacks

Proposed Solution

Add and populate the properties in the HelmChart

export class HelmChart extends Construct {
  public abstract readonly chart: string;
  public abstract readonly repository: string;
  public abstract readonly version: string;
  public abstract readonly chartAsset: Asset;
  ....

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.90.0

Environment details (OS name and version, etc.)

Windows

@pergardebrink pergardebrink added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@pergardebrink pergardebrink changed the title (module name): (short issue description) aws-eks: Add properties from IHelmChartOptions to HelmChart construct Aug 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Aug 9, 2023
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 9, 2023
@peterwoodworth
Copy link
Contributor

If having the properties exposed will help for some use cases then it makes sense

@davidcosc
Copy link
Contributor

Hi @peterwoodworth,
this is my first contribution attempt.
I interpreted the desired change as a refactor since there seem to be no changes to the generated CloudFormation or any behavioral changes that might impact synthesis. At least as far as I know of. I hope i didn't miss anything.

@mergify mergify bot closed this as completed in #26852 Aug 23, 2023
mergify bot pushed a commit that referenced this issue Aug 23, 2023
…s for HelmChart construct (#26852)

> This change was made to improve convenience when working with the HelmChart construct.
> For example this allows for simpler creation of aspects for inspecting helm charts as mentioned in #26678 .

Closes #26678.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
3 participants