-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eks: ProxyAgent is not a constructor #26771
Comments
Can you share the smallest code snippet to reproduce this error? |
this is also breaking my eks deployment on v2.92. reverted back to v2.91 and seems to be fixed (fwiw- the only difference on the diffs from 2.91->2.92 was the OIDC handler) cfn error:
lambda logs from handler:
|
Could you please share your CDK code which reproduces this? |
Pretty sure this was caused by #26722, reproduced with the eks cluster integ test. Just need to change to import to correctly use the 6.0 export. Working on a fix. |
When we [upgraded the proxy-agent v6](#26722) we did not update how we were importing from the package. Where [in 5.0 commonjs exports were used](https://github.com/TooTallNate/node-proxy-agent/blob/5.0.0/index.js#L25) , in [6.0 a named esm export is used](https://github.com/TooTallNate/proxy-agents/blob/proxy-agent%406.1.0/packages/proxy-agent/src/index.ts#L71). Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use `import` instead of `require`. Fixes: #26771
When we [upgraded the proxy-agent v6](#26722) we did not update how we were importing from the package. Where [in 5.0 commonjs exports were used](https://github.com/TooTallNate/node-proxy-agent/blob/5.0.0/index.js#L25) , in [6.0 a named esm export is used](https://github.com/TooTallNate/proxy-agents/blob/proxy-agent%406.1.0/packages/proxy-agent/src/index.ts#L71). Updated to use a named import statement instead of a default require. Typescript also confirms the old import was an error now since we use `import` instead of `require`. Fixes: #26771 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Describe the bug
The newest cdk library (2.92.0) produces this error. Downgrading to 2.90.0 solves it. We create clusters where we specify the
kubectl_layer
parameter.Expected Behavior
it shouldn't fail
Current Behavior
I'm getting this error:
Reproduction Steps
See descr
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.89.0
Framework Version
2.92.0
Node.js Version
v18.17.0
OS
Ubuntu
Language
Python
Language Version
Python 3.8
Other information
No response
The text was updated successfully, but these errors were encountered: