Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CDK CodeDeploy: Support more then one NLB #27407

Closed
1 of 2 tasks
mmilkin opened this issue Oct 4, 2023 · 2 comments · Fixed by #27607
Closed
1 of 2 tasks

CDK CodeDeploy: Support more then one NLB #27407

mmilkin opened this issue Oct 4, 2023 · 2 comments · Fixed by #27607
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md hacktoberfest Good issue for hacktoberfest-ers p2

Comments

@mmilkin
Copy link

mmilkin commented Oct 4, 2023 •
edited
Loading

Describe the feature

Code Deploy deployment-group.ts only supports a single loadbalancer

https://github.com/aws/aws-cdk/blob/ae24fbff8133c452f72f5c276997e2fb707e054c/packages/aws-cdk-lib/aws-codedeploy/lib/server/deployment-group.ts#L372C11-L372C27

I belive that more then one NLB is supported

Use Case

Have more then one NLB in the Deployment group

Proposed Solution

Change the structure to take a list of NLBs

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

v2.99.1

Environment details (OS name and version, etc.)

AL2
@mmilkin mmilkin added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2023
@mmilkin mmilkin changed the title (module name): (short issue description) CDK CodeDeploy: Support more then one NLB Oct 4, 2023
@github-actions github-actions bot added the @aws-cdk/aws-codedeploy Related to AWS CodeDeploy label Oct 4, 2023
@peterwoodworth peterwoodworth added good first issue Related to contributions. See CONTRIBUTING.md p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 4, 2023
@peterwoodworth
Copy link
Contributor

Yep, makes sense. Thanks for the request!

Until this is implemented, you could work around this with escape hatches 🙂

@peterwoodworth peterwoodworth removed their assignment Oct 4, 2023
@scanlonp scanlonp added the hacktoberfest Good issue for hacktoberfest-ers label Oct 4, 2023
@nicolastremblay1 nicolastremblay1 mentioned this issue Oct 10, 2023
Closed
@nicolastremblay1 nicolastremblay1 mentioned this issue Oct 19, 2023
Merged
@mergify mergify bot closed this as completed in #27607 Oct 27, 2023
mergify bot pushed a commit that referenced this issue Oct 27, 2023
@nicolastremblay1
feat(codedeploy): support multiple load balancers for deployment grou…
d57504e 
…ps (#27607)

### Summary
This change adds multiple load balancer support for CodeDeploy deployment groups.

There is a currently a loadBalancer field in the ServerDeploymentGroup, adding loadBalancers might be a good field to extend the functionality to create a deployment group with multiple load balancers.

Closes #27407
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@github-actions github-actions bot mentioned this issue Nov 1, 2023
Closed
mrgrain pushed a commit that referenced this issue Nov 1, 2023
@nicolastremblay1 @mrgrain
feat(codedeploy): support multiple load balancers for deployment grou…
4f7243e 
…ps (#27607)

### Summary
This change adds multiple load balancer support for CodeDeploy deployment groups.

There is a currently a loadBalancer field in the ServerDeploymentGroup, adding loadBalancers might be a good field to extend the functionality to create a deployment group with multiple load balancers.

Closes #27407
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md hacktoberfest Good issue for hacktoberfest-ers p2
Projects
None yet
Milestone
No milestone
3 participants
@mmilkin @peterwoodworth @scanlonp