Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-scheduler-targets-alpha): Add SnsPublish Target #27459

Closed
1 of 2 tasks
filletofish opened this issue Oct 9, 2023 · 5 comments · Fixed by #27838
Closed
1 of 2 tasks

(aws-scheduler-targets-alpha): Add SnsPublish Target #27459

filletofish opened this issue Oct 9, 2023 · 5 comments · Fixed by #27838
Labels
@aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@filletofish
Copy link
Contributor

filletofish commented Oct 9, 2023

Describe the feature

Work to support L2 constructs for AWS Scheduler is in progress (#23394). See the approved RFC. RFC planned to add 12 templates targets, but only Lambda Invoke is currently implemented (#26575).

This issue tracks implementation of SnsPublish target to publish a message to a SNS topic.

Use Case

Customers would like to use templated target SnsPublish to be able to publish a message to a SNS topic. on schedule. L2 target construct should grant required permissions to the AWS Scheduler to publish a message to a SNS topic.

Proposed Solution

The proposed solution needs to be adopted to the recent examples of LambdaInvoke (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/aws-scheduler-targets-alpha/lib/lambda-invoke.ts).

Solution should also include unit and integration tests.

export class SnsPublish extends ScheduleTargetBase {
    constructor(
      private readonly topic: sns.ITopic,
      private readonly props: ScheduleTargetBaseProps,
    ) {
      super(props, topic.topicArn);
    }

    protected addTargetActionToRole(role: iam.IRole): void {
     // TODO: Check if target and schedule are in the same account and region
     // TODO: Check if target and role are in the same account

      this.topic.grantPublish(role);      
    }
  }

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.99.1

Environment details (OS name and version, etc.)

MacOS

@filletofish filletofish added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@github-actions github-actions bot added the @aws-cdk/aws-sns Related to Amazon Simple Notification Service label Oct 9, 2023
@pahud
Copy link
Contributor

pahud commented Oct 9, 2023

Thank you for all those feature requests and PRs!

@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 9, 2023
@kaizencc kaizencc reopened this Oct 11, 2023
@aws aws deleted a comment from github-actions bot Oct 11, 2023
@kaizencc kaizencc added @aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service and removed @aws-cdk/aws-sns Related to Amazon Simple Notification Service labels Oct 11, 2023
@ymhiroki
Copy link
Contributor

@filletofish
Hi, Filipp! I'm interested in this feature.
Are you already working on this? If not, I'll take it.

@filletofish
Copy link
Contributor Author

filletofish commented Oct 22, 2023

@ymhiroki absolutely, please feel free to lead this!

I have created this and other issues for event scheduler to get support of the community in progressing the development of this model

@ymhiroki
Copy link
Contributor

OK, Thanks! I start the implementation.

@mergify mergify bot closed this as completed in #27838 Nov 29, 2023
mergify bot pushed a commit that referenced this issue Nov 29, 2023
Closes #27459 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

chenjane-dev pushed a commit to chenjane-dev/aws-cdk that referenced this issue Dec 5, 2023
Closes aws#27459 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-scheduler Related to the AWS Scheduler service @aws-cdk/aws-scheduler-targets Related to targets of the AWS Scheduler service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
4 participants