Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS::GlobalAccelerator: Add the ability to set the BYOIP IP Addresses for the Global Accelerator. #28209

Closed
2 tasks
werebear73-tritelph opened this issue Nov 30, 2023 · 5 comments
Labels
@aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@werebear73-tritelph
Copy link

Describe the feature

The feature being requested is the ability to set the IP Addresses (BYOIP) during Accelerator construction. The presumed method would be as parameters in the AcceleratorProps.

Use Case

When creating a stack with a global accelerator, the application should have IP Address in the customer owned range so the reverse lookup on the IP addresses show the company not AWS as the owner. This can help with brand awareness and support issue resolution.

Proposed Solution

Add new properties to the AcceleratorProps interface for IpAddresses and IpAddressType mapping to the CloudFormation AWS::GlobalAccelerator::Accelerator properties of the same name. Whereby the IpAddresses is an array of strings contains the IP Addresses to be assigned to the global accelerator. And the IpAddressType property is string with restricted values of DUAL_STACK | IPV4 in accordance with the CloudFormation property. These properties would be optional; however, setting either value requires that the other value by set as well.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.111.0 (build 2ccb59e)

Environment details (OS name and version, etc.)

Windows 11, Visual Studio 2022 Community Edition, .Net 6

@werebear73-tritelph werebear73-tritelph added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 30, 2023
@github-actions github-actions bot added the @aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator label Nov 30, 2023
@msambol
Copy link
Contributor

msambol commented Dec 1, 2023

This is a dupe of #28051 right ? Will be closed by #28055.

@msambol
Copy link
Contributor

msambol commented Dec 1, 2023

ah maybe not a direct dupe but I added this functionality in that PR as well.

@werebear73-tritelph
Copy link
Author

Thank you, Michael.

@khushail
Copy link
Contributor

khushail commented Dec 1, 2023

thanks @michael-k for submitting this.
@msambol , appreciate your contribution on this request. Since this is a duplicate , I am closing this request.

@khushail khushail closed this as completed Dec 1, 2023
@khushail khushail added duplicate This issue is a duplicate. p2 and removed needs-triage This issue or PR still needs to be triaged. labels Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@khushail khushail added the effort/small Small work item – less than a day of effort label Dec 1, 2023
mergify bot pushed a commit that referenced this issue Dec 21, 2023
Closes #28051, #28209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
paulhcsun pushed a commit to paulhcsun/aws-cdk that referenced this issue Jan 5, 2024
…8055)

Closes aws#28051, aws#28209.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-globalaccelerator Related to AWS Global Accelerator duplicate This issue is a duplicate. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

No branches or pull requests

3 participants