Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-stepfunctions-tasks: Support for new HTTPS Endpoint integration #28278

Closed
1 of 2 tasks
MathieuGilbert opened this issue Dec 6, 2023 · 6 comments · Fixed by #28673 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Closed
1 of 2 tasks

aws-stepfunctions-tasks: Support for new HTTPS Endpoint integration #28278

MathieuGilbert opened this issue Dec 6, 2023 · 6 comments · Fixed by #28673 or rwlxxvii/containers#124 · May be fixed by NOUIY/aws-solutions-constructs#98, NOUIY/aws-solutions-constructs#99 or NOUIY/aws-solutions-constructs#101
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@MathieuGilbert
Copy link
Contributor

Describe the feature

Support for the newly released HTTPS Endpoints Step Functions integration:

Use Case

CDK should support the HttpInvoke Step Functions integration, so it can be managed via IaC.

Proposed Solution

Task should allow specifying all standard, optional, and required parameters (endpoint, HTTP method, EventBridge Connection ARN, headers, body, query string, etc.).

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

latest

Environment details (OS name and version, etc.)

N/A
@MathieuGilbert MathieuGilbert added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2023
@MathieuGilbert MathieuGilbert changed the title (aws-stepfunctions-tasks): (Support for new HTTPS Endpoint integration) aws-stepfunctions-tasks: Support for new HTTPS Endpoint integration Dec 6, 2023
@khushail khushail added the investigating This issue is being investigated and/or work is in progress to resolve the issue. label Dec 6, 2023
@khushail
Copy link
Contributor

khushail commented Dec 6, 2023

Thanks @MathieuGilbert for submitting this request and volunteering for the PR contribution.

@khushail khushail added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. needs-triage This issue or PR still needs to be triaged. labels Dec 6, 2023
@github-actions github-actions bot mentioned this issue Jan 1, 2024
Closed
@boringContributor
Copy link

@MathieuGilbert hey there, do you already use this with a workaround? would also love to contribute somehow as I desperately need this construct :D

@MathieuGilbert
Copy link
Contributor Author

@MathieuGilbert hey there, do you already use this with a workaround? would also love to contribute somehow as I desperately need this construct :D

Hi @boringContributor, we aren't using this yet, but have plenty of Lambdas doing this manually which we'd love to replace. I have an initial implementation of this, I just need to find the time to test & polish it, hopefully this coming week.

@MathieuGilbert MathieuGilbert mentioned this issue Jan 11, 2024
Merged
@MathieuGilbert
Copy link
Contributor Author

@boringContributor Just wanted to update you as I've made some progress and have a WIP draft PR here. I tested it out by copying the construct to an existing project and it works if the Connection is set up right. It can be used that way if you don't want to wait for it to make it into the library. The only internal import can be hard-coded as Resource: 'arn:aws:states:::http:invoke'.

@MathieuGilbert
Copy link
Contributor Author

@khushail What's the process for getting #28673 reviewed now that it's ready?

This was referenced Feb 29, 2024
Open
Open
@mergify mergify bot closed this as completed in #28673 Apr 16, 2024
mergify bot pushed a commit that referenced this issue Apr 16, 2024
@MathieuGilbert
feat(stepfunctions-tasks): add httpinvoke step functions task (#28673)
178e481 
This adds an `HttpInvoke` Step Functions task construct, which allows calling public APIs as described [here](https://docs.aws.amazon.com/step-functions/latest/dg/connect-third-party-apis.html).

- Accepts an Event Bridge API Destination `IConnection`, setting required permissions to use its credentials.
- Grants permission to invoke the root path for the endpoint (`apiRoot` prop). This allows passing the relative endpoint path at execution time (`apiEndpoint` prop).
- Defines an enum for the allowed options for the URL encoding style of arrays, used when encoding the request body.

Closes #28278

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 23, 2024
Open
Open
@rwlxxvii rwlxxvii mentioned this issue May 27, 2024
Merged
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this issue Jun 13, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 14, 2024
Open
@snyk-io snyk-io bot mentioned this issue Jun 20, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 20, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@MathieuGilbert @boringContributor @khushail