-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Amazon.CDK.AWS.Apigatewayv2.Integrations namespace still missing with 2.114.1. #28348
Comments
I was able to import that from VSCode with cdk 2.114.1 import {
aws_apigatewayv2 as apigwv2,
aws_apigatewayv2_authorizers as apigwv2_authorizers,
aws_apigatewayv2_integrations as apigwv2_integrations,
} from 'aws-cdk-lib';
export class DemoStack extends Stack {
readonly fn: lambda.IFunction;
constructor(scope: Construct, id: string, props: StackProps) {
super(scope, id, props);
const fn = lambda.Function.fromFunctionName(this, 'LambdaFunc', 'dummy');
const defaultIntegration = new apigwv2_integrations.HttpLambdaIntegration('LambdaInteg', fn)
new apigwv2.HttpApi(this, 'Api', {
defaultIntegration,
});
}
}
|
It working for npm package does not mean it will work for NuGet package. |
Ouch so it turns out the official Integrations module has been renamed to a very un-.NET namespace of |
Issue appears to be reproducible in version
These namespaces should have followed consistent namespace after experimental construct was promoted to publicly supported L2 construct. My assumption is that this could be an issue with .NET package release process where it might have taken input from TypeScript packages NOTE: This should be tested in other languages (like Java) as well. Needs review with team. |
… jsiirc (#30461) ### Issue # (if applicable) Closes #28348 ### Reason for this change When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. ### Description of changes We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`. ### Description of how you validated changes N/A ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
… jsiirc (aws#30461) ### Issue # (if applicable) Closes aws#28348 ### Reason for this change When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. ### Description of changes We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`. ### Description of how you validated changes N/A ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
… jsiirc (aws#30461) ### Issue # (if applicable) Closes aws#28348 ### Reason for this change When we promote apigatewayv2 from experimental to stable module, we did not add `jsiirc.json` file, thus no documentation is created and the namespace for import is incorrect. ### Description of changes We cannot fix the namespace now as this is stable modules and there're customers using it. Fixing this would be a breaking change to users who use apigatewayv2 in `aws-cdk-lib`. ### Description of how you validated changes N/A ### Checklist - [ ] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the bug
#28255 closed so reporting new one.
Apparently 2.114.0 is supposed to include the missing Amazon.CDK.AWS.Apigatewayv2 sub-modules and namespaces, but they are still regarded as non-existent by Visual Studio.
Expected Behavior
Amazon.CDK.AWS.Apigatewayv2.Integrations namespace (and HttpAlbIntegration) available from Amazon.CDK.Lib package.
Current Behavior
Amazon.CDK.AWS.Apigatewayv2.Integrations namespace does not exist.
Reproduction Steps
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.111.0
Framework Version
.NET 6.0
Node.js Version
18.9.0
OS
Windows 11
Language
.NET
Language Version
C# 10
Other information
No response
The text was updated successfully, but these errors were encountered: