-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-cloudfront: support KeyValueStore #28377
Comments
This is awesome! CloudFormation support is coming soon. We definitely should support that when it arrives to cloudformation. |
Hello. Do we know when support for this will be added to CloudFormation and CDK? Curious as I have a project at work that wants to use this feature. Thank you. |
I see https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-cloudfront-keyvaluestore.html is now documented; I can go ahead and take an initial stab at this if community contributions are something the team is interested in for this construct. |
Okay so I went ahead and got started in #28473; however, I am concerned about the usability of the construct. Reviewing the CloudFormation documentation and resource specification, it seems that at the moment CloudFormation doesn't actually support associating the Key Value Store with a function (in either direction). This means users would either need to do this manually or the user/library would need a custom resource. @pahud is there any way to get an indication of whether there will be CloudFormation support for the associations? It seems silly for the library to go through the effort to create a custom resource to do so if it'll be supported natively in a couple revisions of the spec. |
Yes looks like this resource is missing a functionArn property or maybe a new association resource. I will cut an internal ticket to relevant team to clarify but I can't guarantee the response. I would recommend to create an issue to https://github.com/aws-cloudformation/cloudformation-coverage-roadmap/issues as well and link it back to this issue for more community visibility. |
ticket ID V1175345449 |
This adds an initial resource to support creating a Key Value Store and specifying an import source. Unfortunately, CloudFormation doesn't seem to support specifying the `KeyValueStoreAssociations` property of a function so there isn't a way to actually associate the store with a function. Closes #28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This adds an initial resource to support creating a Key Value Store and specifying an import source. Unfortunately, CloudFormation doesn't seem to support specifying the `KeyValueStoreAssociations` property of a function so there isn't a way to actually associate the store with a function. Closes aws#28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Hi @kylelaker The kv store association is defined in the function resource instead, see: I've seen your PR #28571 WIP. Thank you! |
Thanks! #28571 should implement that. Association support was in a separate service spec update after the initial launch but it should be ready now. |
CloudFormation now supports specifying [`KeyValueStoreAssocations`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-keyvaluestoreassociation.html) on a `AWS::CloudFront::Function`. This adds that support to the CDK. Even though the field is plural (in CloudFormation and the API), [a function can have one value store](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/kvs-with-functions-associate.html) so the implementation here tries to provide a nicer API around that. If a Key Value Store is specified, the function will default to `js-2.0` instead of `js-1.0`. Behavior for existing functions is retained. Additionally, an error is thrown if 1.0 is used. Closes #28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
CloudFormation now supports specifying [`KeyValueStoreAssocations`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-keyvaluestoreassociation.html) on a `AWS::CloudFront::Function`. This adds that support to the CDK. Even though the field is plural (in CloudFormation and the API), [a function can have one value store](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/kvs-with-functions-associate.html) so the implementation here tries to provide a nicer API around that. If a Key Value Store is specified, the function will default to `js-2.0` instead of `js-1.0`. Behavior for existing functions is retained. Additionally, an error is thrown if 1.0 is used. Closes aws#28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
CloudFormation now supports specifying [`KeyValueStoreAssocations`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-function-keyvaluestoreassociation.html) on a `AWS::CloudFront::Function`. This adds that support to the CDK. Even though the field is plural (in CloudFormation and the API), [a function can have one value store](https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/kvs-with-functions-associate.html) so the implementation here tries to provide a nicer API around that. If a Key Value Store is specified, the function will default to `js-2.0` instead of `js-1.0`. Behavior for existing functions is retained. Additionally, an error is thrown if 1.0 is used. Closes #28377. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Describe the feature
Hi! Are there any plans of supporting the new Cloudfront KeyValueStore feature in cdk?
Use Case
I'd like to
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.115.0
Environment details (OS name and version, etc.)
Ubuntu 22
The text was updated successfully, but these errors were encountered: