Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: diff --change-set flag not configurable via cdk.json #29232

Open
ben-bourdin451 opened this issue Feb 23, 2024 · 3 comments · May be fixed by #29375
Open

cli: diff --change-set flag not configurable via cdk.json #29232

ben-bourdin451 opened this issue Feb 23, 2024 · 3 comments · May be fixed by #29375
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI

Comments

@ben-bourdin451
Copy link

ben-bourdin451 commented Feb 23, 2024

Describe the bug

A new flag was introduced as part of #28336

This flag doesn't seem to be set to wanted default value using the cdk.json.

There's also missing documentation about this flag in the CLI reference. Arguably a different issue since it'll be a different repo? I'm not sure how to report that. Feel free to point me in the right direction.

Expected Behavior

Ability to override default value in cdk.json

Current Behavior

Anything set in in the cdk.json will be ignored

Reproduction Steps

  1. Use any stack setup
  2. Run a diff
  3. You'll see the following output on the stack:
Hold on while we create a read-only change set to get a diff with accurate replacement information (use --no-change-set to use a less accurate but faster template-only diff)
  1. Try to override the change-set flag in cdk.json to false
  2. Run diff again

expected: warning message above dissapears
actual: still seeing the warning (behaviour hasn't changed)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.128.0

Framework Version

No response

Node.js Version

v20.11.1

OS

darwin ARM64

Language

TypeScript

Language Version

No response

Other information

No response

@ben-bourdin451 ben-bourdin451 added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2024
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Feb 23, 2024
@andreialecu
Copy link
Contributor

Piggy backing on this issue to request that the log message be suppressed if the flag is configured explicitly in cdk.json. It just pollutes logs unnecessarily (we have many stacks).

@pahud pahud added p2 feature-request A feature should be added or improved. cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort and removed bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2024
@ben-bourdin451
Copy link
Author

I'm happy to try and solve this myself if someone points me in the right direction. I took a quick look at the code however it's not immediately obvious how/where these flags are passed through via the cdk.json file

andreialecu added a commit to andreialecu/aws-cdk that referenced this issue Mar 6, 2024
@andreialecu andreialecu linked a pull request Mar 6, 2024 that will close this issue
1 task
@andreialecu
Copy link
Contributor

Opened #29375 with some changes for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli Issues related to the CDK CLI effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants