Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-stepfunction-tasks): Support enableExecuteCommand in EcsRunTask #29637

Closed
1 of 2 tasks
matthiasgubler opened this issue Mar 28, 2024 · 3 comments · Fixed by #29638 · 4 remaining pull requests
Closed
1 of 2 tasks

(aws-stepfunction-tasks): Support enableExecuteCommand in EcsRunTask #29637

matthiasgubler opened this issue Mar 28, 2024 · 3 comments · Fixed by #29638 · 4 remaining pull requests
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@matthiasgubler
Copy link
Contributor

matthiasgubler commented Mar 28, 2024 •
edited
Loading

Describe the feature

Add a property enableExecuteCommand to the EcsRunTaskProps, to start the task from step functions with execution command enabled.

Use Case

We need to set up a debug task on dev, which currently is no supported easily in CDK

Proposed Solution

Add property on creation of EcsRunTask

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

aws-cdk-lib@2.134.0

Environment details (OS name and version, etc.)

Mac OS 14
@matthiasgubler matthiasgubler added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 28, 2024
matthiasgubler added a commit to matthiasgubler/aws-cdk that referenced this issue Mar 28, 2024
@matthiasgubler
Add enableExecuteCommand to sfn ECSRunTask
01ff241 
Fixes aws#29637
@matthiasgubler matthiasgubler mentioned this issue Mar 28, 2024
Merged
1 task
matthiasgubler added a commit to matthiasgubler/aws-cdk that referenced this issue Mar 28, 2024
@matthiasgubler
Add enableExecuteCommand to sfn ECSRunTask
c17fb1c 
Fixes aws#29637
matthiasgubler added a commit to matthiasgubler/aws-cdk that referenced this issue Mar 28, 2024
@matthiasgubler
Add enableExecuteCommand to sfn ECSRunTask
ccebd21 
Fixes aws#29637
matthiasgubler added a commit to matthiasgubler/aws-cdk that referenced this issue Mar 28, 2024
@matthiasgubler
Add enableExecuteCommand to sfn ECSRunTask
2f4ef2b 
Fixes aws#29637
@tim-finnigan tim-finnigan self-assigned this Mar 28, 2024
@tim-finnigan tim-finnigan added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Mar 28, 2024
@tim-finnigan
Copy link

Thanks for the feature request and PR!

@tim-finnigan tim-finnigan added p2 effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Mar 28, 2024
@tim-finnigan tim-finnigan removed their assignment Mar 28, 2024
matthiasgubler added a commit to matthiasgubler/aws-cdk that referenced this issue Mar 29, 2024
@matthiasgubler
Add enableExecuteCommand to sfn ECSRunTask
15af2b3 
Fixes aws#29637
This was referenced Apr 1, 2024
Closed
Closed
Closed
@mergify mergify bot closed this as completed in #29638 Apr 1, 2024
mergify bot pushed a commit that referenced this issue Apr 1, 2024
@matthiasgubler
feat(stepfunction): add enableExecuteCommand to sfn ECSRunTask (#29638)
d5b8594 
### Issue #29637

Closes #29637

### Reason for this change
Allow setting the enableExecuteCommand for ECSRunTask in sfn

### Description of changes
Add the enableExecuteCommand property to the EcsRunTaskProps, to start the task from step functions with execution command enabled.

### Description of how you validated changes
Unit-test added. Existing ones passed.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 1, 2024

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced May 23, 2024
Open
Open
@NOUIY NOUIY mentioned this issue May 30, 2024
Open
@NOUIY NOUIY mentioned this issue Jun 7, 2024
Open
@niravparikh05 niravparikh05 mentioned this issue Jun 13, 2024
Open
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-stepfunctions-tasks effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
3 participants
@matthiasgubler @aws-cdk-automation @tim-finnigan