aws-cdk-lib: Possibly incorrect default value spec in type-doc for stickinessCookieDuration for ApplicationTargetGroup #29725
Labels
aws-cdk-lib
Related to the aws-cdk-lib package
bug
This issue is a bug.
effort/small
Small work item – less than a day of effort
p2
Comments
exalted
added
bug
khushail
added
p2
effort/small
mergify bot
pushed a commit
that referenced
this issue
Apr 4, 2024
By default, stickiness is disabled. The duration _is_ one day if stickiness is enabled, but we don't surface that option to users. If `stickinessCookieDuration` is not supplied, stickiness will not be enabled so the 1 day default doesn't make sense here. Closes #29725. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Describe the bug
I believe this type-doc that claims the default value to be "1 days" is not accurate.
Following the code path, I think, the behavior rather is that, if
stickinessCookieDurationwasn't set, then the stickiness is not enabled; and if it is defined it must be between 1 second and 7 days (604800 seconds) —this last bit is correctly specified in the type-doc.Expected Behavior
See issue description
Current Behavior
See issue description
Reproduction Steps
See issue description
Possible Solution
No response
Additional Information/Context
No response
CDK CLI Version
2.125.0 (build 5e3c3c6)
Framework Version
No response
Node.js Version
node v18.19.1
OS
macOS 14.4.1 (23E224)
Language
TypeScript
Language Version
No response
Other information
No response
The text was updated successfully, but these errors were encountered: