Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lambda: Function.fromFunctionArn will strip off the trailing version or alias #30002

Closed
pahud opened this issue Apr 29, 2024 · 2 comments · Fixed by #30003
Closed

lambda: Function.fromFunctionArn will strip off the trailing version or alias #30002

pahud opened this issue Apr 29, 2024 · 2 comments · Fixed by #30003
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug.

Comments

@pahud
Copy link
Contributor

pahud commented Apr 29, 2024

Describe the bug

This PR removed the trailing version or alias of the functionArn and is potentially causing breaking changes.

For example,

If Stack A exporting the functionArn like arn:aws:lambda:us-east-1:123456789012:function:ProcessKinesisRecords:live to Stack B and CDK from Stack B importing that with Function.fromFunctionArn, stack B would have the functionArn with the trailing version or alias stripped off, causing the breaking changes.

Expected Behavior

fromFunctionArn() should not remove the trailing version or alias. We probably implement https://github.com/aws/aws-cdk/pull/29820/files with a feature flag.

Current Behavior

fromFunctionArn() would remove the trailing version or alias.

Reproduction Steps

as described above

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.138.0

Framework Version

No response

Node.js Version

all

OS

all

Language

TypeScript

Language Version

No response

Other information

No response
@pahud pahud added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 29, 2024
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Apr 29, 2024
@pahud pahud mentioned this issue Apr 29, 2024
Merged
1 task
@mergify mergify bot closed this as completed in #30003 Apr 29, 2024
mergify bot pushed a commit that referenced this issue Apr 29, 2024
@pahud
revert: "fix(lambda): version.fromVersionArn creates invalid Version …
0cb9abd 
…object" (#30003)

### Issue # (if applicable)

Revert #29820

Closes #30002

### Reason for this change



### Description of changes



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions GitHub Actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

moelasmar pushed a commit that referenced this issue Apr 29, 2024
@pahud @moelasmar
revert: "fix(lambda): version.fromVersionArn creates invalid Version …
ced7a46 
…object" (#30003)

### Issue # (if applicable)

Revert #29820

Closes #30002

### Reason for this change



### Description of changes



### Description of how you validated changes



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@pahud pahud removed the needs-triage This issue or PR still needs to be triaged. label Apr 30, 2024
This was referenced May 1, 2024
Closed
Closed
Closed
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-lambda Related to AWS Lambda bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

revert: "fix(lambda): version.fromVersionArn creates invalid Version object" pahud/aws-cdk
2 participants
@pahud @aws-cdk-automation