aws-stepfunctions-tasks: EventBridge aws. event source prefix check is more strict than it should be

[FilipPyrek]

Describe the bug

We discovered that the EventBridgePutEvents is throwing an error even in cases when it's not necessary to throw.

For example our source looks like this aws-some-feature.this.that and according to the docs this should be valid.

All events that come from AWS services begin with "aws."

Whereas in the CDK code of EventBridgePutEvents is this check

if (entry.source?.startsWith('aws')) {

The correct implementation should be following

if (entry.source?.startsWith('aws.')) {

Expected Behavior

EventBridgePutEvents should not throw an error when source starts with aws. (but not just aws)

Current Behavior

EventBridgePutEvents throws an error when source starts with aws

Reproduction Steps

Use this task in a state machine.

import { EventBridgePutEvents } from 'aws-cdk-lib/aws-stepfunctions-tasks'

new EventBridgePutEvents(
  this,
  'SendEvent',
  {
    entries: [
      {
        eventBus: 'some-event-bus',
        source: `aws-feature-name-whatever-you-want`,
        detailType: 'some-detail',
        detail: TaskInput.fromJsonPathAt('$')
      }
    ]
  }
)

Possible Solution

Change this line: https://github.com/aws/aws-cdk/blob/205163fc0d2cac84d3d746a98c393e137f0e2388/packages/aws-cdk-lib/aws-stepfunctions-tasks/lib/eventbridge/put-events.ts#L136C7-L136C45

to:

- if (entry.source?.startsWith('aws')) {
+ if (entry.source?.startsWith('aws.')) { 

Additional Information/Context

No response

CDK CLI Version

v2.141.0

Framework Version

No response

Node.js Version

20.x

OS

MacOS (personal) / Ubuntu (in CI)

Language

TypeScript

Language Version

5.4.5

Other information

No response

[pahud]

Makes perfect sense to me. Thank you for the report.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

[aws-cdk-automation]

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.