Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(eks): support for Kubernetes version 1.30 #30454

Merged
merged 5 commits into from
Jun 6, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 5, 2024

Issue # (if applicable)

DependOn:

Closes #30443

Reason for this change

Description of changes

Description of how you validated changes

export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}

$ kubectl get no
NAME STATUS ROLES AGE VERSION
ip-172-31-3-166.ec2.internal Ready 5m38s v1.30.0-eks-036c24b

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels Jun 5, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team June 5, 2024 03:19
@pahud pahud changed the title feat(eks): support k8s 1.30 feat(eks): support for Kubernetes version 1.30 Jun 5, 2024
@pahud pahud added the p1 label Jun 5, 2024
@github-actions github-actions bot removed the p1 label Jun 5, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 5, 2024
@pahud pahud added p1 and removed p2 contribution/core This is a PR that came from AWS. labels Jun 5, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 5, 2024
@pahud pahud added @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service and removed contribution/core This is a PR that came from AWS. labels Jun 5, 2024
@github-actions github-actions bot added p2 and removed p1 labels Jun 5, 2024
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 5, 2024
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 6, 2024 02:12

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pahud
Copy link
Contributor Author

pahud commented Jun 6, 2024

@Mergifyio refresh

Copy link
Contributor

mergify bot commented Jun 6, 2024

refresh

✅ Pull request refreshed

@amazon-codecatalyst amazon-codecatalyst bot force-pushed the pahud/feat-aws-eks-add-support-30443 branch from 75a5e0e to 0fa3b1e Compare June 6, 2024 11:58
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 6, 2024 13:24

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@pahud pahud marked this pull request as ready for review June 6, 2024 13:40
@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2024
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 16ebb54
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

mergify bot commented Jun 6, 2024

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit d2ea280 into aws:main Jun 6, 2024
18 checks passed
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jun 6, 2024
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this pull request Jun 11, 2024
### Issue # (if applicable)

- Similar to aws#29040, this PR adds 1.30 support.
- Update all existing integ tests for `V1_29` and make sure they deploy with `V1_30`.

DependOn:
- [x] cdklabs/awscdk-asset-kubectl#838
- [x] cdklabs/awscdk-asset-kubectl#860

Closes aws#30443

### Reason for this change



### Description of changes



### Description of how you validated changes

```ts
export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}
```

$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-172-31-3-166.ec2.internal   Ready    <none>   5m38s   v1.30.0-eks-036c24b



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
### Issue # (if applicable)

- Similar to aws#29040, this PR adds 1.30 support.
- Update all existing integ tests for `V1_29` and make sure they deploy with `V1_30`.

DependOn:
- [x] cdklabs/awscdk-asset-kubectl#838
- [x] cdklabs/awscdk-asset-kubectl#860

Closes aws#30443

### Reason for this change



### Description of changes



### Description of how you validated changes

```ts
export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}
```

$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-172-31-3-166.ec2.internal   Ready    <none>   5m38s   v1.30.0-eks-036c24b



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@aws-cdk-automation
Copy link
Collaborator

Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one.

@aws aws locked as resolved and limited conversation to collaborators Jul 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service contribution/core This is a PR that came from AWS. effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(aws-eks): add support for EKS version 1.30
3 participants