Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support 1.30 #860

Merged
merged 2 commits into from
Jun 5, 2024
Merged

feat: Support 1.30 #860

merged 2 commits into from
Jun 5, 2024

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Jun 4, 2024 •
edited
Loading

Fixes #838

@pahud pahud mentioned this pull request Jun 5, 2024
Merged
3 tasks
kaizencc
kaizencc reviewed Jun 5, 2024
View reviewed changes
test/kubectl-layer.integ.ts Outdated
*/
function overrideProviderRuntime(construct?: IConstruct[]) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of this shouldn't we update min cdk version to a version that doesnt have node14 as the framework runtime?

Copy link
Contributor

@awsdataarchitect awsdataarchitect Jun 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaizencc @pahud I did the same in #623 by upgrading aws-cdk-lib from 2.28.0 to 2.85.0. Suggest approve that PR first to validate this

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@awsdataarchitect yes your PR is for 1.29.0 which is still relevant. My PR is for 1.30 branch though.

GavinZZ
GavinZZ approved these changes Jun 5, 2024
View reviewed changes
Copy link

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for making this change.

@mergify mergify bot merged commit 567c68f into cdklabs:kubectl-v30/main Jun 5, 2024
12 checks passed
@pahud pahud mentioned this pull request Jun 6, 2024
Closed
mergify bot pushed a commit to aws/aws-cdk that referenced this pull request Jun 6, 2024
@pahud
feat(eks): support for Kubernetes version 1.30 (#30454)
d2ea280 
### Issue # (if applicable)

- Similar to #29040, this PR adds 1.30 support.
- Update all existing integ tests for `V1_29` and make sure they deploy with `V1_30`.

DependOn:
- [x] cdklabs/awscdk-asset-kubectl#838
- [x] cdklabs/awscdk-asset-kubectl#860

Closes #30443

### Reason for this change



### Description of changes



### Description of how you validated changes

```ts
export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}
```

$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-172-31-3-166.ec2.internal   Ready    <none>   5m38s   v1.30.0-eks-036c24b



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Leo10Gama pushed a commit to Leo10Gama/aws-cdk that referenced this pull request Jun 11, 2024
@pahud
feat(eks): support for Kubernetes version 1.30 (aws#30454)
3b193c1 
### Issue # (if applicable)

- Similar to aws#29040, this PR adds 1.30 support.
- Update all existing integ tests for `V1_29` and make sure they deploy with `V1_30`.

DependOn:
- [x] cdklabs/awscdk-asset-kubectl#838
- [x] cdklabs/awscdk-asset-kubectl#860

Closes aws#30443

### Reason for this change



### Description of changes



### Description of how you validated changes

```ts
export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}
```

$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-172-31-3-166.ec2.internal   Ready    <none>   5m38s   v1.30.0-eks-036c24b



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mazyu36 pushed a commit to mazyu36/aws-cdk that referenced this pull request Jun 22, 2024
@pahud @mazyu36
feat(eks): support for Kubernetes version 1.30 (aws#30454)
575c4b6 
### Issue # (if applicable)

- Similar to aws#29040, this PR adds 1.30 support.
- Update all existing integ tests for `V1_29` and make sure they deploy with `V1_30`.

DependOn:
- [x] cdklabs/awscdk-asset-kubectl#838
- [x] cdklabs/awscdk-asset-kubectl#860

Closes aws#30443

### Reason for this change



### Description of changes



### Description of how you validated changes

```ts
export class EksClusterLatestVersion extends Stack {
  constructor(scope: Construct, id: string, props: StackProps) {
    super(scope, id, props);

    const vpc = new ec2.Vpc(this, 'Vpc', { natGateways: 1 });
    const mastersRole = new iam.Role(this, 'Role', {
      assumedBy: new iam.AccountRootPrincipal(),
    });

    // create eks.Cluster of the latest k8s version
    new eks.Cluster(this, 'Cluster', {
      vpc,
      mastersRole,
      version: eks.KubernetesVersion.V1_30,
      kubectlLayer: new KubectlV30Layer(this, 'KubectlLayer'),
      defaultCapacity: 1,
    });
  }
}
```

$ kubectl get no
NAME                           STATUS   ROLES    AGE     VERSION
ip-172-31-3-166.ec2.internal   Ready    <none>   5m38s   v1.30.0-eks-036c24b



### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@awsdataarchitect awsdataarchitect mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaizencc kaizencc kaizencc left review comments

@awsdataarchitect awsdataarchitect awsdataarchitect left review comments

@GavinZZ GavinZZ GavinZZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pahud @GavinZZ @awsdataarchitect @kaizencc