Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(rds): add performanceInisghts configuration at cluster level #31375

Closed
2 tasks
aprat84 opened this issue Sep 9, 2024 · 2 comments · Fixed by #31385
Closed
2 tasks

(rds): add performanceInisghts configuration at cluster level #31375

aprat84 opened this issue Sep 9, 2024 · 2 comments · Fixed by #31385
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2

Comments

@aprat84
Copy link

aprat84 commented Sep 9, 2024

Describe the feature

Add the performance insights configuration options at cluster level:

/**
 * Whether to enable Performance Insights for the DB instance.
 *
 * @default - false, unless `performanceInsightRetention` or `performanceInsightEncryptionKey` is set.
 */
readonly enablePerformanceInsights?: boolean;

/**
 * The amount of time, in days, to retain Performance Insights data.
 *
 * @default 7
 */
readonly performanceInsightRetention?: PerformanceInsightRetention;

/**
 * The AWS KMS key for encryption of Performance Insights data.
 *
 * @default - default master key
 */
readonly performanceInsightEncryptionKey?: kms.IKey;

Use Case

So we don't need to configure it to all instances. Also, because CloufFormation allows it.

Proposed Solution

Add the same 3 configuration options present in DatabaseInstance class, to the DatabaseCluster class: enablePerformanceInsights, performanceInsightRetention and performanceInsightEncryptionKey.

Other Information

https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbcluster.html#cfn-rds-dbcluster-performanceinsightsenabled

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.256

Environment details (OS name and version, etc.)

macOS 14.6.1

@aprat84 aprat84 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2024
@github-actions github-actions bot added the @aws-cdk/aws-rds Related to Amazon Relational Database label Sep 9, 2024
@pahud pahud added p2 effort/medium Medium work item – several days of effort and removed needs-triage This issue or PR still needs to be triaged. labels Sep 9, 2024
@pahud
Copy link
Contributor

pahud commented Sep 9, 2024

Makes sense to me. Please help us prioritize with 👍 and we welcome PRs for this.

@mergify mergify bot closed this as completed in #31385 Oct 15, 2024
mergify bot pushed a commit that referenced this issue Oct 15, 2024
#31385)

### Issue # (if applicable)

Closes #31375 .

### Reason for this change



Properties for Performance Insights at cluster level are supported in L1, but not in L2.

### Description of changes



Added the properties in props for Database Cluster.

### Description of how you validated changes



Both unit tests and integ tests.

### Checklist
- [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
@aws-cdk/aws-rds Related to Amazon Relational Database effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants