-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cli: Respect --build option in cdk.json as well #32329
Comments
Appears to be valid feature request to support @acomagu Feel free to contribute PR that could be reviewed by the team. They should get back to you in case of any concerns or review comments. |
@ashishdhingra Thank you for your insight! Unfortunately I won't be able to start working on PR in at least a week, but I intend to do it sooner or later. But I also don't intend to prevent others from make PR. |
Afaik this feature has already been available via cdk.json. edit) found the PR: #17176. It seems |
@tmokmss Thanks for your reply. Unsure if this is documented in CDK guide. @acomagu Could you please give it a try and if it works, kindly close the issue. |
@ashishdhingra I found this doc somewhat relevant:
But the problem is that it is not clear what |
Thanks for the feedback. I'll pass this note along for considerations of consistency for some upcoming work. |
Comments on closed issues and PRs are hard for our team to see. |
Describe the feature
The
--build
option was introduced forcdk deploy
orcdk watch
command at #19663, but the equivalent field in cdk.json is not introduced.This issue proposes to support
build
field to cdk.json as well as--build
flag.Use Case
Rather than add
--build ./build.sh
flag each time executingcdk deploy
, it's convenient if we could write the build command to cdk.json, likeProposed Solution
Support
build
field in cdk.json.Other Information
No response
Acknowledgements
CDK version used
2.165.0
Environment details (OS name and version, etc.)
Linux acm-envy3-win 5.15.167.4-microsoft-standard-WSL2 #1 SMP Tue Nov 5 00:21:55 UTC 2024 x86_64 GNU/Linux
The text was updated successfully, but these errors were encountered: