Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial external release #1

Merged
merged 36 commits into from
May 30, 2018
Merged

Initial external release #1

merged 36 commits into from
May 30, 2018

Conversation

eladb
Copy link
Contributor

@eladb eladb commented May 30, 2018

Initial external release of the CDK codebase

Elad Ben-Israel and others added 5 commits May 30, 2018 12:18
Co-authored-by: Rico Huijbers <huijbers@amazon.nl>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.lu>
Co-authored-by: Mitch Garnaat <garnaat@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Romain Marcadier-Muller <rmuller@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.nl>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.lu>
Co-authored-by: Rico Huijbers <huijbers@amazon.nl>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.lu>
@@ -0,0 +1,13 @@
When implementing this:

https://issues-dub.amazon.com/issues/SDK-3348
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

for (const az of azs) {

// TODO: this will not be needed in the future
// https://sim.amazon.com/issues/SDK-3376
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Elad Ben-Israel and others added 17 commits May 30, 2018 13:15
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Marcadier-Muller, Romain <rmuller@amazon.com>
Co-authored-by: Romain Marcadier-Muller <rmuller@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Breland Miley <brelandm@amazon.com>
Co-authored-by: Romain Marcadier-Muller <rmuller@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Mitch Garnaat <garnaat@amazon.com>
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
Co-authored-by: Shiv Lakshminarayan <shivlaks@amazon.com>
Co-authored-by: Rico Huijbers <huijbers@amazon.com>
Co-authored-by: Max Hall <hallmaxw@amazon.com>
Co-authored-by: Adam Ruka <adamruka@amazon.com>
@Crycham Crycham mentioned this pull request Aug 5, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants