CLI should have backwards compatibility test on CX protocol version #4475
Assignees
Labels
Comments
rix0rrr
added
ops-excellence
rix0rrr
added a commit
that referenced
this issue
Oct 22, 2019
Make sure that the CLI will continue to be able to load old cloud assemblies. We do this by using the CLI feature that it can directly load Cloud Assemblies through its `--app` argument, hard copying a couple of cloud assemblies into the test set and trying to synth those. In addition to adding a test for loading v0.36.0 assemblies, also add tests for 2 common context provider requests (AZs and VPC), to make sure new CLIs will continue to be able to handle these context lookup requests. Fixes #4475, pre-emptively adds a regression test for #4544.
mergify bot
pushed a commit
that referenced
this issue
Oct 25, 2019
* fix(cli): add Cloud Assembly backwards compat tests Make sure that the CLI will continue to be able to load old cloud assemblies. We do this by using the CLI feature that it can directly load Cloud Assemblies through its `--app` argument, hard copying a couple of cloud assemblies into the test set and trying to synth those. In addition to adding a test for loading v0.36.0 assemblies, also add tests for 2 common context provider requests (AZs and VPC), to make sure new CLIs will continue to be able to handle these context lookup requests. Fixes #4475, pre-emptively adds a regression test for #4544. * Address review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To avoid a repeat of #4294, we should check that an old CX assembly can be read by all new CLIs.
A simple implementation of this would be generating a CX assembly today once, and writing an integ test that uses a bash script as CX app that copies that CX assembly's files into
cdk.out.cdk synthshould parse that assembly without errors.Internal reference: coe/116228
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: