Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Permit IAM Role Injection Into AwsCustomResource #4906

Closed
1 of 2 tasks
reillykw opened this issue Nov 7, 2019 · 0 comments · Fixed by #4909
Closed
1 of 2 tasks

Permit IAM Role Injection Into AwsCustomResource #4906

reillykw opened this issue Nov 7, 2019 · 0 comments · Fixed by #4909
Assignees
@eladb
Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. in-progress This issue is being actively worked on.

Comments

@reillykw
Copy link
Contributor

reillykw commented Nov 7, 2019 •
edited
Loading

Right now the AwsCustomResource creates the role that the lambda will use for resource CRUD. Would like it if the role could be injected. The alternative, of course, is an escape hatch with a deletion override and setting it there. This could be a preferred method of going around the current implementation. If that is the case I can close this issue.

Use Case

The IAM resource needed to run this code must be created in some other stack. I can't use this feature unless the Role can be referenced from another stack.

Proposed Solution

Add an IRole parameter for the AwsCustomResourceProps interface, optional, and if present is used for instantiation of the SingletonFunction.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@reillykw reillykw added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Nov 7, 2019
jogold added a commit to jogold/aws-cdk that referenced this issue Nov 7, 2019
@jogold
feat(custom-resources): allow specifying role for AwsCustomResource
f64e96b 
Also removed console.log outputs from tests

Closes aws#4906
@jogold jogold mentioned this issue Nov 7, 2019
Merged
@SomayaB SomayaB added in-progress This issue is being actively worked on. @aws-cdk/custom-resources Related to AWS CDK Custom Resources and removed needs-triage This issue or PR still needs to be triaged. labels Nov 8, 2019
@mergify mergify bot closed this as completed in #4909 Nov 10, 2019
mergify bot pushed a commit that referenced this issue Nov 10, 2019
@jogold @mergify
feat(custom-resources): allow specifying role for AwsCustomResource (#…
98fb888 
…4909)

* feat(custom-resources): allow specifying role for AwsCustomResource

Also removed console.log outputs from tests

Closes #4906

* update doc for role
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/custom-resources Related to AWS CDK Custom Resources feature-request A feature should be added or improved. in-progress This issue is being actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(custom-resources): allow specifying role for AwsCustomResource jogold/aws-cdk
3 participants
@eladb @SomayaB @reillykw