Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws-eks] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 #7216

Closed
1 of 2 tasks
pahud opened this issue Apr 7, 2020 · 12 comments · Fixed by #8787
Closed
1 of 2 tasks

[aws-eks] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 #7216

pahud opened this issue Apr 7, 2020 · 12 comments · Fixed by #8787
Assignees
@pahud @eladb @iliapolo
Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Milestone
[DevPreview] @aws...

Comments

@pahud
Copy link
Contributor

pahud commented Apr 7, 2020

bump helm3 and kubectl versions from the latest release of aws-samples/aws-lambda-layer-kubectl 2.0.0-beta3

Use Case

  1. we need the support to create new namespace with addChart() in aws-eks.
    [aws-eks]: Deploy Helm chart to EKS via CDK #3748 (comment)
  1. Amazon EKS 1.15 has been released for a while. Let's bump the kubectl version to 1.15.

Proposed Solution

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pahud pahud added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 7, 2020
@SomayaB SomayaB added the @aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service label Apr 9, 2020
@eladb eladb mentioned this issue Apr 12, 2020
Closed
@eladb eladb added the effort/small Small work item – less than a day of effort label Apr 12, 2020
@farshadniayeshpour
Copy link

Any update on this?

@pahud
Copy link
Contributor Author

pahud commented Apr 17, 2020

@FarshadNiayesh

--create-namespace will be shipped in Helm v3.2.0 helm/helm#7648 (comment)

Will continue this when v3.2.0 is released.

@farshadniayeshpour
Copy link

@pahud seems like Helm v3.2.0 is released. Should we expect this feature any time soon in CDK?

@pahud
Copy link
Contributor Author

pahud commented Apr 23, 2020

@FarshadNiayesh Absolutely. I'll try it in my environment tomorrow and see how it works. Thanks.

@jonathanmccracken
Copy link

This would help me also

@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label May 19, 2020
@arjanschaaf
Copy link
Contributor

Any update on this @pahud ? This would make the combination CDK + EKS + Helm so much easier to work with :-)

@pahud
Copy link
Contributor Author

pahud commented Jun 16, 2020

I'll look into this again and get back to this thread tomorrow. Thanks for the headsup.

@eladb eladb added this to the EKS Developer Preview milestone Jun 24, 2020
@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

Would be nice to include this as part of #6279

@eladb eladb changed the title create k8s namespace with Helm3 and kubectl 1.15 support [EKS Feature] create k8s namespace with Helm3 and kubectl 1.15 support Jun 24, 2020
@eladb eladb changed the title [EKS Feature] create k8s namespace with Helm3 and kubectl 1.15 support [EKS Feature] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 Jun 24, 2020
@eladb eladb mentioned this issue Jun 24, 2020
Closed
@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

@pahud can we also include the latest CLI in this upgrade so it will address #6279 (comment)

@eladb eladb mentioned this issue Jun 24, 2020
Closed
@eladb eladb removed this from the EKS Developer Preview milestone Jun 24, 2020
@pahud
Copy link
Contributor Author

pahud commented Jun 24, 2020

Yap. Just bumpped aws-lambda-layer-kubectl to release 2.0.0 with the latest kubectl, awscli and helm3.

Layer is also available in SAR and might take 24-48hours to replicate to all global regions.

I will test the latest layer in the next 1-2 days and create a PR for aws-eks cdk construct.

kubectl v1.16.8-eks-e16311
awscli 1.18.86
helm 3.2.4
jq 1.6
GNU Make 3.82

@eladb
Copy link
Contributor

eladb commented Jun 24, 2020

🤝

@pahud pahud mentioned this issue Jun 25, 2020
Merged
@SomayaB SomayaB added the in-progress This issue is being actively worked on. label Jun 25, 2020
@pahud pahud mentioned this issue Jun 29, 2020
Merged
@SomayaB SomayaB changed the title [EKS Feature] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 [EKS] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 Jun 29, 2020
@eladb
Copy link
Contributor

eladb commented Jun 29, 2020

Resolved by #8739

@eladb eladb closed this as completed Jun 29, 2020
mergify bot pushed a commit that referenced this issue Jun 30, 2020
@pahud
chore(eks): support create namespace with helm (#8787)
973fa42 
chore(eks): support create namespace with helm 

- add `createNamespace` property for `eks.HelmChart`
- set the `wait` flag correctly for HelmChart custom resource

Fixes: #7216 #7209 #8713

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@iliapolo iliapolo added this to the EKS Dev Preview milestone Aug 10, 2020
@iliapolo iliapolo removed the in-progress This issue is being actively worked on. label Aug 16, 2020
@iliapolo iliapolo changed the title [EKS] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 [aws-eks] Upgrade to kubectl 1.15 & AWS CLI 1.18.70 Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pahud pahud

@eladb eladb

@iliapolo iliapolo

Labels
@aws-cdk/aws-eks Related to Amazon Elastic Kubernetes Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved.
Projects
None yet
Milestone
[DevPreview] @aws-cdk/aws-eks
Development

Successfully merging a pull request may close this issue.

chore(eks): support create namespace with helm
7 participants
@pahud @eladb @iliapolo @jonathanmccracken @arjanschaaf @SomayaB @farshadniayeshpour