User Data - add_s3_download_command missing --region so it fails to download in the ISOLATED zone through S3 VPC gateway

[DharmSonariya]

asset = Asset(self, "Asset", path=path.join(__dirname, "configure.sh"))
instance = ec2.Instance(self, "Instance", {})
local_path = instance.user_data.add_s3_download_command(
    bucket=asset.bucket,
    bucket_key=asset.s3_object_key
)
instance.user_data.add_execute_file_command(
    file_path=local_path,
    arguments="--verbose -y"
)
asset.grant_read(instance.role)

Above Python code generate User Data

#!/bin/bash
mkdir -p $(dirname '/tmp/assets/fa08d934445838dab921670b0d40be6d9d261063663fbc9cd7cfd7e6691d233d.zip')
aws s3 cp 's3://cdktoolkit-stagingbucket-silds9kng0ra/assets/fa08d934445838dab921670b0d40be6d9d261063663fbc9cd7cfd7e6691d233d.zip' '/tmp/assets/fa08d934445838dab921670b0d40be6d9d261063663fbc9cd7cfd7e6691d233d.zip'

Which is perfectly working in the private zone. But when deploy instance in the ISOLATED zone its fail to download through S3 VPC Gateway. Manually adding --region with aws s3 cp command, then it works.

[pachicoo]

Any progress on this? It is a big hurdle to configure instances in an isolated zone.
I trust this matter will identify it as a high priority.

[ghost]

Any progress ?

[LukvonStrom]

@DharmSonariya If I understand the issue correctly you want to have the ability to specify the region parameter for the aws s3 cp command? My suggestion is implementing this, but only if set explicitly.
I.e. it is not added in case no region parameter is provided to `add_s3_download_command, but when a region parameter is provided it is added.

[DharmSonariya]

@DharmSonariya If I understand the issue correctly you want to have the ability to specify the region parameter for the aws s3 cp command? My suggestion is implementing this, but only if set explicitly.
I.e. it is not added in case no region parameter is provided to `add_s3_download_command, but when a region parameter is provided it is added.

It seems to be the perfect solution.

[LukvonStrom]

@DharmSonariya my proposed PR should suffice to fix your issue.

[DharmSonariya]

@DharmSonariya my proposed PR should suffice to fix your issue.

Thank you for your time and effort.

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.