Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cloudwatch] Add number widget format option to SingleValueWidget #8940

Closed
2 tasks
pushthat opened this issue Jul 8, 2020 · 1 comment · Fixed by #12274
Closed
2 tasks

[cloudwatch] Add number widget format option to SingleValueWidget #8940

pushthat opened this issue Jul 8, 2020 · 1 comment · Fixed by #12274
Assignees
@rix0rrr
Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@pushthat
Copy link

pushthat commented Jul 8, 2020

Would it be possible to have the number widget format option added to SingleValueWidget ?

Use Case

This option is already included in aws cloudwatch dashboard single value widget. One cool use case would be the display of current SLI for example.

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@pushthat pushthat added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 8, 2020
@github-actions github-actions bot added the @aws-cdk/aws-cloudwatch Related to Amazon CloudWatch label Jul 8, 2020
@pushthat pushthat changed the title [cloudwatch] [cloudwatch] Add number widget format option to SingleValueWidget Jul 8, 2020
@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md labels Jul 8, 2020
@rix0rrr rix0rrr added the p2 label Aug 12, 2020
@SomayaB SomayaB removed the needs-triage This issue or PR still needs to be triaged. label Nov 6, 2020
yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
Closes aws#8940 and Closes aws#12066
07d95f2
yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
feat(cloudwatch): Add support for showing full precision with SingleV…
9924725 
…alueWidgets

Closes aws#8940 and Closes aws#12066
yattoni added a commit to yattoni/aws-cdk that referenced this issue Dec 29, 2020
@yattoni
feat(cloudwatch): support showing full precision with SingleValueWidgets
8cf4fcf 
Closes aws#8940 and Closes aws#12066
@yattoni yattoni mentioned this issue Dec 29, 2020
Merged
@mergify mergify bot closed this as completed in #12274 Jan 6, 2021
mergify bot pushed a commit that referenced this issue Jan 6, 2021
@yattoni
feat(cloudwatch): full precision for SingleValueWidgets (#12274)
45d78f0 
Closes #8940 and Closes #12066

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jan 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-cloudwatch Related to Amazon CloudWatch effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cloudwatch): full precision for SingleValueWidgets yattoni/aws-cdk
3 participants
@rix0rrr @pushthat @SomayaB