Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): fix missing single quote #10047

Merged
merged 2 commits into from
Aug 31, 2020
Merged

chore(cli): fix missing single quote #10047

merged 2 commits into from
Aug 31, 2020

Conversation

rayou
Copy link
Contributor

@rayou rayou commented Aug 29, 2020

Fix missing quote in python post-installed message.

Before

Initializing a new git repository...
Please run python3 -m venv .env'!
Executing Creating virtualenv...

After

Initializing a new git repository...
Please run 'python3 -m venv .env'!
Executing Creating virtualenv...

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

fix missing quote in python post-installed message.
@ghost
Copy link

ghost commented Aug 29, 2020

Taking a step back, the Toolkit executes the command given in the message; the user doesn't need to. This message could probably be removed entirely.

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 4a40fb7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f5dbed6 into aws:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants