Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipelines): sanity check on asset path #10155

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

rix0rrr
Copy link
Contributor

@rix0rrr rix0rrr commented Sep 3, 2020

A user was reporting an infinite loop in pipeline updating.

Couldn't really get to the root cause of why that was happening, but in
order to get closer to the root cause, add a sanity check and ask people
to report similar issues.

Closes #9932, relates to #9766.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

A user was reporting an infinite loop in pipeline updating.

Couldn't really get to the root cause of why that was happening, but in
order to get closer to the root cause, add a sanity check and ask people
to report similar issues.

Closes #9932, relates to #9766.
@rix0rrr rix0rrr requested a review from a team September 3, 2020 13:07
@rix0rrr rix0rrr self-assigned this Sep 3, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 3, 2020
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 070614b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 1001e0c into master Sep 8, 2020
@mergify mergify bot deleted the huijbers/asset-sanity-check branch September 8, 2020 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cdk-pipelines] Detect and fail if cloud assembly is being synthesized to tempdir
4 participants