fix(cfn-include): correctly parse YAML strings in short-form GetAtt #10197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njlynch
reviewed
Sep 8, 2020
njlynch
approved these changes
Sep 8, 2020
We weren't recursively parsing the argument of the short-form Fn::GetAtt if the arguments to it where given in the string form; which meant, if they were quoted (which is legal in YAML), we would add the quote to the logical ID of the resource, which is obviously incorrect. Fixes aws#10177
skinny85
force-pushed
the
fix/cfn-include-yaml-getatt-short-quoted
branch
from
1b1acf2 to
80e5bed
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We weren't recursively parsing the argument of the short-form
Fn::GetAttif the arguments to it where given in the string form;
which meant, if they were quoted (which is legal in YAML),
we would add the quote to the logical ID of the resource,
which is obviously incorrect.
Fixes #10177
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license