fix(rds): Make most DatabaseClusterAttributes properties optional #10291
Conversation
The `IDatabaseCluster` interface has a lot of properties, putting a large strain on users who want to import clusters via `DatabaseClusterAttributes`. This alters the attributes interface to contain almost exclusively optional props, and lazily throw if any missing properties are accessed. I believe this is a backwards-compatible change, but someone please double-check me on that. fixes #3587
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| */ | ||
| readonly port: number; | ||
| readonly clusterIdentifier: string; |
There was a problem hiding this comment.
any reason we wouldn't want to just call it clusterId - don't think we expand it out to identifier in many places do we?
| */ | ||
| readonly instanceIdentifiers: string[]; | ||
| readonly instanceIdentifiers?: string[]; |
There was a problem hiding this comment.
was this why we went with clusterIdentifier for the property name, or was there another reason?
The
IDatabaseClusterinterface has a lot of properties, putting a large strainon users who want to import clusters via
DatabaseClusterAttributes. Thisalters the attributes interface to contain almost exclusively optional props,
and lazily throw if any missing properties are accessed.
I believe this is a backwards-compatible change, but someone please double-check
me on that.
fixes #3587
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license