Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(core): add missing maturities #10351

Merged
merged 11 commits into from
Sep 16, 2020
Merged

chore(core): add missing maturities #10351

merged 11 commits into from
Sep 16, 2020

Conversation

ericzbeard
Copy link
Contributor

A few packages were missing the maturity property.

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 14, 2020
@njlynch njlynch requested a review from a team September 15, 2020 10:40
@njlynch njlynch added the pr/do-not-merge This PR should not be merged at this time. label Sep 15, 2020
Copy link
Contributor

@njlynch njlynch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but marked as do not merge in case you think my comment merits more discussion.

@njlynch njlynch removed the pr/do-not-merge This PR should not be merged at this time. label Sep 16, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: f91f32d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Sep 16, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b0b9c53 into aws:master Sep 16, 2020
Copy link
Contributor

@eladb eladb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering how come this was not discovered by pkglint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants