fix(redshift): cluster defaultChild broken after adding subnet group #10389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njlynch
force-pushed
the
njlynch/redshift-subnet-group-fix
branch
from
a43bdea to
ba424e8
Compare
The new ClusterSubnetGroup L2 was added to the cluster in #10340. However, adding this resource with an id of `Default` (to preserve backwards compatibility), means that the implicit logic of `this.node.defaultChild` breaks. Flipping the order, so the ClusterSubnetGroup uses `Default` as the logical ID, fixes both issues.
njlynch
force-pushed
the
njlynch/redshift-subnet-group-fix
branch
from
ba424e8 to
2b77d0c
Compare
rix0rrr
approved these changes
Sep 16, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new ClusterSubnetGroup L2 was added to the cluster in #10340.
However, adding this resource with an id of
Default(to preserve backwardscompatibility), means that the implicit logic of
this.node.defaultChildbreaks.
Flipping the order, so the ClusterSubnetGroup uses
Defaultas the logical ID,fixes both issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license