Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ecs-patterns): add ruleName optional parameter for ScheduledTask constructs #11007

Closed
wants to merge 5 commits into from
Closed

feat(ecs-patterns): add ruleName optional parameter for ScheduledTask constructs #11007

wants to merge 5 commits into from

Conversation

martavoi
Copy link

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Oct 21, 2020 •
edited
Loading

@martavoi martavoi force-pushed the ecs_sceduled_task_rule_name branch 2 times, most recently from 552e396 to a4826b1 Compare October 21, 2020 10:45
@SomayaB SomayaB added the @aws-cdk/aws-ecs-patterns Related to ecs-patterns library label Oct 26, 2020
SoManyHs
SoManyHs previously requested changes Nov 10, 2020
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @martavoi! Could you update the test expectation? You can see the failing tests in the CodeBuild logs.

Thanks!

packages/@aws-cdk/aws-ecs-patterns/lib/base/scheduled-task-base.ts
* A name for the rule.
*
* @default - AWS CloudFormation generates a unique physical ID and uses that ID
* for the rule name. For more information, see Name Type.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be nice to include the link to the docs: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-name.html

@mergify mergify bot dismissed SoManyHs’s stale review November 17, 2020 18:06

Pull request has been modified.

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: ca23190
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SoManyHs SoManyHs mentioned this pull request Dec 22, 2020
Merged
@SoManyHs
Copy link
Contributor

Closing in favor of #12190.

@SoManyHs SoManyHs closed this Dec 22, 2020
mergify bot pushed a commit that referenced this pull request Dec 22, 2020
@SoManyHs
feat(ecs-patterns): add ruleName optional parameter for ScheduledTask…
b1318bd 
… constructs (#12190)

Closes #11007

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
@SoManyHs @flochaz
feat(ecs-patterns): add ruleName optional parameter for ScheduledTask…
a106f33 
… constructs (aws#12190)

Closes aws#11007

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs left review comments

Assignees
No one assigned
Labels
@aws-cdk/aws-ecs-patterns Related to ecs-patterns library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@martavoi @aws-cdk-automation @SoManyHs @uttarasridhar @MrArnoldPalmer @SomayaB