Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): refactor CloudFormationLang.toJSON() #11224

Merged
merged 8 commits into from
Mar 10, 2021

Commits on Oct 30, 2020

  1. refactor(core): refactor CloudFormationLang.toJSON()

    Our previous implementation of `toJSON()` was quite hacky.
    
    It replaced values inside the structure with objects that had a custom
    `toJSON()` serializer, and then called `JSON.stringify()` on the result.
    
    The resulting JSON would have special markers in it where the Token
    values would be string-substituted back in.
    
    It's actually easier and gives us more control to just implement
    JSONification ourselves in a Token-aware recursive function.
    
    This change has been split off from a larger, upcoming PR in order
    to make the individual reviews smaller.
    rix0rrr committed Oct 30, 2020
    Configuration menu
    Copy the full SHA
    cc4ad0f View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2021

  1. Configuration menu
    Copy the full SHA
    48419c9 View commit details
    Browse the repository at this point in the history
  2. Change approach a bit

    rix0rrr committed Mar 9, 2021
    Configuration menu
    Copy the full SHA
    d5a96db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c483b97 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f988812 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a5275a3 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2021

  1. Configuration menu
    Copy the full SHA
    80731c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fc942e4 View commit details
    Browse the repository at this point in the history