Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(aws-cdk-lib): minimum supported node version is now v14 #11964

Merged
merged 11 commits into from
Jan 15, 2021
Merged

chore(aws-cdk-lib): minimum supported node version is now v14 #11964

merged 11 commits into from
Jan 15, 2021

Conversation

nija-at
Copy link
Contributor

@nija-at nija-at commented Dec 9, 2020 •
edited
Loading

This is the current active LTS version and is a good minimum
requirement.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

chore(aws-cdk-lib): set minimum node version to v14 LTS
d94dc44 
This is the current lowest active LTS version and is a good minimum
bar.
@nija-at nija-at requested review from RomainMuller and a team December 9, 2020 16:15
@nija-at nija-at self-assigned this Dec 9, 2020
@gitpod-io
Copy link

gitpod-io bot commented Dec 9, 2020 •
edited
Loading

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Dec 9, 2020
@nija-at nija-at added the pr/do-not-merge This PR should not be merged at this time. label Dec 18, 2020
@eladb
Copy link
Contributor

eladb commented Dec 23, 2020

This should be widely advertised as we release v2.0. Please make sure we have that in our doc change checklist

RomainMuller
RomainMuller reviewed Jan 15, 2021
View reviewed changes
tools/pkglint/lib/rules.ts Outdated
@@ -1079,7 +1079,11 @@ export class MustHaveNodeEnginesDeclaration extends ValidationRule {
public readonly name = 'package-info/engines';

public validate(pkg: PackageJson): void {
expectJSON(this.name, pkg, 'engines.node', '>= 10.13.0 <13 || >=13.7.0');
if (pkg.json.name === 'aws-cdk-lib') {
expectJSON(this.name, pkg, 'engines.node', '>= 14.15.1');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it needs to be this edgy. This might block people with "not entirely up-to-date" environments from using the product... We could require the 14.x line, but not be too strict about it... Some early 14.0.0 would be best, IMO - like one that's known to have feature stability.

@nija-at nija-at changed the title chore(aws-cdk-lib): set minimum node version to v14 LTS feat(aws-cdk-lib): minimum supported node version is now v14 Jan 15, 2021
@github-actions github-actions bot added the aws-cdk-lib Related to the aws-cdk-lib package label Jan 15, 2021
@nija-at nija-at changed the title feat(aws-cdk-lib): minimum supported node version is now v14 chore(aws-cdk-lib): minimum supported node version is now v14 Jan 15, 2021
@nija-at nija-at removed the pr/do-not-merge This PR should not be merged at this time. label Jan 15, 2021
@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Jan 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 4aa64c8 into master Jan 15, 2021
@mergify mergify bot deleted the nija-at/v2-node14 branch January 15, 2021 14:51
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 2a889f8
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mohanrajendran pushed a commit to mohanrajendran/aws-cdk that referenced this pull request Jan 24, 2021
chore(aws-cdk-lib): minimum supported node version is now v14 (aws#11964
d05c98e 
)

This is the current active LTS version and is a good minimum
requirement.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@njlynch njlynch mentioned this pull request Sep 9, 2021
Closed
rix0rrr pushed a commit that referenced this pull request Oct 18, 2021
@rix0rrr
chore(aws-cdk-lib): minimum supported node version is now v14 (#11964)
e807e89 
This is the current active LTS version and is a good minimum
requirement.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@rix0rrr rix0rrr mentioned this pull request Oct 18, 2021
Merged
mergify bot pushed a commit that referenced this pull request Oct 18, 2021
@rix0rrr
chore(v2): minimum supported node version is now v14 (#17036)
d0a27c1 
This is the current active LTS version and is a good minimum requirement.

Re-introduction of #11964. Fixes #16438


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
@rix0rrr @TikiTDO
chore(v2): minimum supported node version is now v14 (aws#17036)
e4e09d2 
This is the current active LTS version and is a good minimum requirement.

Re-introduction of aws#11964. Fixes aws#16438


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomainMuller RomainMuller RomainMuller approved these changes

@shivlaks shivlaks shivlaks approved these changes

Assignees

@nija-at nija-at

Labels
aws-cdk-lib Related to the aws-cdk-lib package contribution/core This is a PR that came from AWS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nija-at @eladb @aws-cdk-automation @RomainMuller @shivlaks