feat(codebuild): prevent using Secrets in plain-text environment variables #12150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Probably should wait with merging this until #12121 is merged. |
skinny85
added
the
pr-linter/exempt-readme
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ables If you use a Secret in an environment variable of the default type `BuildEnvironmentVariableType.PLAINTEXT`, it will be visible in plain text in the AWS Console. Add validation that checks for this common mistake, along with a flag that allows you to opt out of it.
skinny85
force-pushed
the
feat/codebuild-env-var-secrets
branch
from
063d1bc
to
364f4e8
Compare
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
…ables (aws#12150) If you use a Secret in an environment variable of the default type `BuildEnvironmentVariableType.PLAINTEXT`, it will be visible in plain text in the AWS Console. Add validation that checks for this common mistake, along with a flag that allows you to opt out of it. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use a Secret in an environment variable of the default type
BuildEnvironmentVariableType.PLAINTEXT,it will be visible in plain text in the AWS Console.
Add validation that checks for this common mistake,
along with a flag that allows you to opt out of it.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license