-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ecs): deployment circuit breaker support #12168
Conversation
copy @iamhopaul123 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much for contributing! Overall looks good to me. Just one suggestion.
Co-authored-by: Penghao He <penghaoh@amazon.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Just got confirmed internally that rollback
depends on the CB and doesn't make any sense if CB is not enabled, though it won't error out because it doesn't validate deployment configuration.
@MrArnoldPalmer any thought or concern on this? |
Pull request has been modified.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
feat(ecs): deployment circuit breaker support This PR allows you to enable the `deployment circuit breaker` support for Amazon ECS. Depends on - [ ] cfnspec v22 aws#12170 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
feat(ecs): deployment circuit breaker support
This PR allows you to enable the
deployment circuit breaker
support for Amazon ECS.Depends on
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license