Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ecs): deployment circuit breaker support #12168

Merged
merged 8 commits into from
Dec 23, 2020
Merged

feat(ecs): deployment circuit breaker support #12168

merged 8 commits into from
Dec 23, 2020

Conversation

pahud
Copy link
Contributor

@pahud pahud commented Dec 20, 2020

feat(ecs): deployment circuit breaker support

This PR allows you to enable the deployment circuit breaker support for Amazon ECS.

Depends on


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Dec 20, 2020

@pahud
Copy link
Contributor Author

pahud commented Dec 21, 2020

copy @iamhopaul123

@pahud pahud marked this pull request as ready for review December 21, 2020 14:08
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for contributing! Overall looks good to me. Just one suggestion.

packages/@aws-cdk/aws-ecs/lib/base/base-service.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-ecs/lib/base/base-service.ts Outdated Show resolved Hide resolved
iamhopaul123
iamhopaul123 previously approved these changes Dec 22, 2020
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Just got confirmed internally that rollback depends on the CB and doesn't make any sense if CB is not enabled, though it won't error out because it doesn't validate deployment configuration.

@iamhopaul123 iamhopaul123 added the pr/do-not-merge This PR should not be merged at this time. label Dec 22, 2020
@iamhopaul123
Copy link
Contributor

@MrArnoldPalmer any thought or concern on this?

@mergify mergify bot dismissed stale reviews from iamhopaul123 and SoManyHs December 22, 2020 23:31

Pull request has been modified.

@SoManyHs SoManyHs added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Dec 22, 2020
@SoManyHs SoManyHs self-assigned this Dec 22, 2020
@iamhopaul123 iamhopaul123 removed the pr/do-not-merge This PR should not be merged at this time. label Dec 23, 2020
@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Dec 23, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e8801a0 into aws:master Dec 23, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 1889dbd
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

flochaz pushed a commit to flochaz/aws-cdk that referenced this pull request Jan 5, 2021
feat(ecs): deployment circuit breaker support

This PR allows you to enable the `deployment circuit breaker` support for Amazon ECS.

Depends on 

- [ ] cfnspec v22 aws#12170


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants