chore(eks): Remove legacy and deprecated code #12189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-eks
iliapolo
commented
Dec 21, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
added
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Do it!
…On Mon, Dec 21, 2020 at 6:29 PM Eli Polonsky ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In ***@***.***/aws-eks/lib/cluster.ts
<#12189 (comment)>:
> - * drop-in replacement for `eks.Cluster` with `kubectlEnabled: false`.
- *
- * Bear in mind that this is a temporary workaround. We have plans to remove
- * `eks.LegacyCluster`. If you have a use case for using `eks.LegacyCluster`,
- * please add a comment here #9332 and
- * let us know so we can make sure to continue to support your use case with
- * `eks.Cluster`. This issue also includes additional context into why this
- * class is being removed.
- *
- * @deprecated `eks.LegacyCluster` is __temporarily__ provided as a drop-in
- * replacement until you are able to migrate to `eks.Cluster`.
- *
- * @see #9332
- * @default true
- */
- readonly kubectlEnabled?: boolean;
I was having doubts about this since it might cause some minor breakage,
but thought it's probably ok since it was deprecated...
Any objections?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#12189 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAIL5YBRTRRPPCXWMZ7YC3SV7K6DANCNFSM4VE3RP6Q>
.
--
Philip M. Gollucci
IT Executive and Engineering Leader
http://www.linkedin.com/in/pgollucci/
301.818.0719
|
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
Removing `LegacyCluster` and the `kubectlEnabled` property. Closes aws#11929 BREAKING CHANGE: `LegacyCluster` was removed since it existed only for a transition period to allow gradual migration to the current cluster class. - eks: `kubectlEnabled` property was removed, all clusters now support `kubectl`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
LegacyClusterand thekubectlEnabledproperty.Closes #11929
BREAKING CHANGE:
LegacyClusterwas removed since it existed only for a transition period to allow gradual migration to the current cluster class.kubectlEnabledproperty was removed, all clusters now supportkubectl.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license