chore: discourage AdministratorAccess policy #12196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though we can't actually suggest any particular policy to use other than `AdministratorAccess`, we've been requested to make it very clear that developers shouldn't be using `AdministratorAccess` without thinking (after an engagement in which an organization's CCoE was displeased with individual developer teams copy/pasting example bootstrapping commands from our developer guides). Add a note to tell developers to check with their organization's CCoE before using `AdministratorAccess`.
|
|
iliapolo
reviewed
Dec 22, 2020
Comment on lines
653
to
656
| > to your account, and can potentially make changes that affect your security posture. | ||
| > Its use requires complete trust in the code and dependencies that make up your CDK app. | ||
| > Check with the appropriate department within your organization to decide on the | ||
| > proper policy to use. |
There was a problem hiding this comment.
Trying to make it a little less threatening, take it leave it...
Suggested change
| > to your account, and can potentially make changes that affect your security posture. | |
| > Its use requires complete trust in the code and dependencies that make up your CDK app. | |
| > Check with the appropriate department within your organization to decide on the | |
| > proper policy to use. | |
| > to your account. Make sure you trust all the code and dependencies that make up your CDK app.. | |
| > We recommend to check with the appropriate department within your organization to decide on the | |
| > proper policy to use. |
iliapolo
approved these changes
Dec 22, 2020
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
Even though we can't actually suggest any particular policy to use other than `AdministratorAccess`, we've been requested to make it very clear that developers shouldn't be using `AdministratorAccess` without thinking (after an engagement in which an organization's CCoE was displeased with individual developer teams copy/pasting example bootstrapping commands from our developer guides). Add a note to tell developers to check with their organization's CCoE before using `AdministratorAccess`. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Even though we can't actually suggest any particular policy to use
other than
AdministratorAccess, we've been requested to make itvery clear that developers shouldn't be using
AdministratorAccesswithout thinking (after an engagement in which an organization's
CCoE was displeased with individual developer teams copy/pasting
example bootstrapping commands from our developer guides).
Add a note to tell developers to check with their organization's CCoE
before using
AdministratorAccess.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license