Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda): Code.fromDockerBuildAsset #12258

Merged
merged 14 commits into from
Feb 18, 2021

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Dec 29, 2020

Use the result of a Docker build as code. The runtime code is expected to be
located at /asset in the image.

Also deprecate BundlingDockerImage in favor of DockerImage.

Closes #11914


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Use the result of a Docker build as code. The runtime code is expected to be
located at `/asset` in the image.

Also deprecate `BundlingDockerImage` in favor of `DockerImage`.
@gitpod-io
Copy link

gitpod-io bot commented Dec 29, 2020

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Dec 29, 2020
@jogold
Copy link
Contributor Author

jogold commented Dec 29, 2020

@eladb

eladb
eladb previously requested changes Dec 29, 2020
packages/@aws-cdk/core/lib/bundling.ts Show resolved Hide resolved
packages/@aws-cdk/core/lib/bundling.ts Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review December 29, 2020 12:32

Pull request has been modified.

@nija-at nija-at assigned eladb and unassigned nija-at Jan 6, 2021
eladb
eladb previously requested changes Feb 17, 2021
packages/@aws-cdk/aws-lambda/lib/code.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/core/lib/bundling.ts Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/README.md Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/README.md Show resolved Hide resolved
@mergify mergify bot dismissed eladb’s stale review February 18, 2021 07:45

Pull request has been modified.

@@ -36,6 +36,9 @@ runtime code.
* `lambda.Code.fromAsset(path)` - specify a directory or a .zip file in the local
filesystem which will be zipped and uploaded to S3 before deployment. See also
[bundling asset code](#bundling-asset-code).
* `lambda.Code.fromDockerBuildAsset(path, options)` - use the result of a Docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename this to fromDockerBuild. I don't see how this can be misinterpreted

@eladb
Copy link
Contributor

eladb commented Feb 18, 2021

Very cool feature

@mergify
Copy link
Contributor

mergify bot commented Feb 18, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@eladb
Copy link
Contributor

eladb commented Feb 18, 2021

@rhboyd worth mentioning in next month's blog

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 367359f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda Related to AWS Lambda
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(core): BundlingDockerImage.cp() needs to be explained more in the README
4 participants