chore(cli): IAM differences table printing is broken #12330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing (by mistake) an unrecognized property to the `table` module. This didn't use to be a problem, but the `table` module has suddenly started throwing an "invalid config" error. The cause is a dependency update that happened today. * In #12324, the version of `table` was updated from `6.0.4` to `6.0.7`. * In [6.0.5](https://github.com/gajus/table/releases/tag/v6.0.5), `table` changes the way it does JSON validation of the input configuration ob ject. Didn't dive into all of the changes, but it stands to reason the validator has become more strict and where it *used* to allow additional properties (probably by accident) it no longer does so. Undo the passing of the unused property. This change is a **chore** instead of a **fix** because the change wasn't released yet.
|
|
RomainMuller
approved these changes
Jan 4, 2021
eladb
approved these changes
Jan 4, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Actually, this should not be chore but fix - I have this issue with 1.82 and 1.81 |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
We were passing (by mistake) an unrecognized property to the `table` module. This didn't use to be a problem, but the `table` module has suddenly started throwing an "invalid config" error. The cause is a dependency update that happened today. * In aws#12324, the version of `table` was updated from `6.0.4` to `6.0.7`. * In [6.0.5](https://github.com/gajus/table/releases/tag/v6.0.5), `table` changes the way it does JSON validation of the input configuration ob ject. Didn't dive into all of the changes, but it stands to reason the validator has become more strict and where it *used* to allow additional properties (probably by accident) it no longer does so. Undo the passing of the unused property. This change is a **chore** instead of a **fix** because the change wasn't released yet. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
@klausbadelt are you using Yarn by any chance? This change should not have made it out according to the GitHub release history, and we shrinkwrap the CLI so you shouldn't be seeing this... unless you use Yarn which doesn't honor shrinkwrapping. |
|
Yes, Yarn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were passing (by mistake) an unrecognized property to the
tablemodule.This didn't use to be a problem, but the
tablemodule has suddenlystarted throwing an "invalid config" error. The cause is a dependency
update that happened today.
tablewas updated from6.0.4to6.0.7.tablechanges the way it does JSON validation of the inputconfiguration ob ject.
Didn't dive into all of the changes, but it stands to reason the
validator has become more strict and where it used to allow additional
properties (probably by accident) it no longer does so.
Undo the passing of the unused property.
This change is a chore instead of a fix because the change
wasn't released yet.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license