fix(apigateway): cannot remove first api key from usage plan #12505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is caused by a [commit introduced] back in Nov 2019. The original change tried to be overly ambitious in not triggering a resource replacement on customers who already had a single key usage plan configured. This results in stack update failures for a usage plan with multiple keys, when the **first** key is removed. Removal of the first key re-adjusts the logical ids of all the keys in a way that makes the update look like the first key is changing and a subsequent key is being removed. The fix is to simply not special case the first key. Resource replacement of Usage Plan Key resource should not create any impact on running applications. fixes #11876 [commit introduced]: 142bd0e
|
|
github-actions
bot
added
the
@aws-cdk/aws-apigateway
|
So basically if you remove the first key then second key gets renamed? ouch |
NetaNir
approved these changes
Jan 20, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
mohanrajendran
pushed a commit
to mohanrajendran/aws-cdk
that referenced
this pull request
Jan 24, 2021
This is caused by a [commit introduced] back in Nov 2019. The original change tried to be overly ambitious in not triggering a resource replacement on customers who already had a single key usage plan configured. This results in stack update failures for a usage plan with multiple keys, when the **first** key is removed. Removal of the first key re-adjusts the logical ids of all the keys in a way that makes the update look like the first key is changing and a subsequent key is being removed. The fix is to simply not special case the first key. Resource replacement of Usage Plan Key resource should not create any impact on running applications. fixes aws#11876 [commit introduced]: aws@142bd0e ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by a commit introduced back in Nov 2019.
The original change tried to be overly ambitious in not triggering a
resource replacement on customers who already had a single key usage
plan configured.
This results in stack update failures for a usage plan with multiple
keys, when the first key is removed. Removal of the first key
re-adjusts the logical ids of all the keys in a way that makes the
update look like the first key is changing and a subsequent key is being
removed.
The fix is to simply not special case the first key.
Resource replacement of Usage Plan Key resource should not create any
impact on running applications.
fixes #11876
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license