Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new interfaces for Assets #12700

Merged
merged 5 commits into from
Jan 31, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/@aws-cdk/assets/lib/fs/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ export interface CopyOptions {
* A strategy for how to handle symlinks.
*
* @default Never
* @deprecated use `followSymlinks` instead
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is followSymlinks defined?

Copy link
Contributor Author

@skinny85 skinny85 Jan 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's defined in FileCopyOptions in @aws-cdk/core.

*/
readonly follow?: FollowMode;

Expand Down
19 changes: 16 additions & 3 deletions packages/@aws-cdk/aws-ecr-assets/lib/image-asset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,16 @@ import * as fs from 'fs';
import * as path from 'path';
import * as assets from '@aws-cdk/assets';
import * as ecr from '@aws-cdk/aws-ecr';
import { Annotations, Construct as CoreConstruct, FeatureFlags, IgnoreMode, Stack, Token } from '@aws-cdk/core';
import {
Annotations, AssetStaging, Construct as CoreConstruct, FeatureFlags, FileFingerprintOptions, IgnoreMode, Stack, SymlinkFollowMode, Token,
} from '@aws-cdk/core';
import * as cxapi from '@aws-cdk/cx-api';
import { Construct } from 'constructs';

/**
* Options for DockerImageAsset
*/
export interface DockerImageAssetOptions extends assets.FingerprintOptions {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume changes to this file are not related to your PR description, yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand what you're asking, sorry. They are very much related (in fact, the description explicitly calls out FingerprintOptions).

export interface DockerImageAssetOptions extends assets.FingerprintOptions, FileFingerprintOptions {
/**
* ECR repository name
*
Expand Down Expand Up @@ -137,8 +139,9 @@ export class DockerImageAsset extends CoreConstruct implements assets.IAsset {
// deletion of the ECR repository the app used).
extraHash.version = '1.21.0';

const staging = new assets.Staging(this, 'Staging', {
const staging = new AssetStaging(this, 'Staging', {
...props,
follow: props.followSymlinks ?? toSymlinkFollow(props.follow),
exclude,
ignoreMode,
sourcePath: dir,
Expand Down Expand Up @@ -181,3 +184,13 @@ function validateBuildArgs(buildArgs?: { [key: string]: string }) {
}
}
}

function toSymlinkFollow(follow?: assets.FollowMode): SymlinkFollowMode | undefined {
switch (follow) {
case undefined: return undefined;
case assets.FollowMode.NEVER: return SymlinkFollowMode.NEVER;
case assets.FollowMode.ALWAYS: return SymlinkFollowMode.ALWAYS;
case assets.FollowMode.BLOCK_EXTERNAL: return SymlinkFollowMode.BLOCK_EXTERNAL;
case assets.FollowMode.EXTERNAL: return SymlinkFollowMode.EXTERNAL;
}
}
4 changes: 2 additions & 2 deletions packages/@aws-cdk/aws-s3-assets/lib/asset.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { Construct as CoreConstruct } from '@aws-cdk/core';

const ARCHIVE_EXTENSIONS = ['.zip', '.jar'];

export interface AssetOptions extends assets.CopyOptions, cdk.AssetOptions {
export interface AssetOptions extends assets.CopyOptions, cdk.FileCopyOptions, cdk.AssetOptions {
/**
* A list of principals that should be able to read this asset from S3.
* You can use `asset.grantRead(principal)` to grant read permissions later.
Expand Down Expand Up @@ -128,7 +128,7 @@ export class Asset extends CoreConstruct implements cdk.IAsset {
const staging = new cdk.AssetStaging(this, 'Stage', {
...props,
sourcePath: path.resolve(props.path),
follow: toSymlinkFollow(props.follow),
follow: props.followSymlinks ?? toSymlinkFollow(props.follow),
assetHash: props.assetHash ?? props.sourceHash,
});

Expand Down
51 changes: 37 additions & 14 deletions packages/@aws-cdk/core/lib/fs/options.ts
Original file line number Diff line number Diff line change
Expand Up @@ -56,19 +56,9 @@ export enum IgnoreMode {
* context flag is set.
*/
DOCKER = 'docker'
};

/**
* Obtains applied when copying directories into the staging location.
*/
export interface CopyOptions {
/**
* A strategy for how to handle symlinks.
*
* @default SymlinkFollowMode.NEVER
*/
readonly follow?: SymlinkFollowMode;
}

interface FileOptions {
/**
* Glob patterns to exclude from the copy.
*
Expand All @@ -85,9 +75,30 @@ export interface CopyOptions {
}

/**
* Options related to calculating source hash.
* Options applied when copying directories
*/
export interface CopyOptions extends FileOptions {
/**
* A strategy for how to handle symlinks.
*
* @default SymlinkFollowMode.NEVER
*/
readonly follow?: SymlinkFollowMode;
}

/**
* Options applied when copying directories into the staging location.
*/
export interface FingerprintOptions extends CopyOptions {
export interface FileCopyOptions extends FileOptions {
Comment on lines +80 to +92
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both of these or can we deprecate the former?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, sorry, I don't understand what you're asking here (deprecate which interface?).

Copy link
Contributor

@nija-at nija-at Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to be sorry. It's ok.

I was asking about CopyOptions and FileCopyOptions. They look exactly the same.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, we can deprecate CopyOptions. It's used in a bunch of public classes, so it will require changes to augment CopyOptions with FileCopyOptions in all of these usages, and it's not linked to deprecating @aws-cdk/assets directly.

Let me know if you want to make this part of this PR, or tackle it separately after this is merged.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you get @eladb's eyes on this? He owns and has built this area and it'd best for him to take a look at this PR and assess this change.

I'll defer to him on what the right thing here is.

/**
* A strategy for how to handle symlinks.
*
* @default SymlinkFollowMode.NEVER
*/
readonly followSymlinks?: SymlinkFollowMode;
}

interface ExtraHashOptions {
/**
* Extra information to encode into the fingerprint (e.g. build instructions
* and other inputs)
Expand All @@ -96,3 +107,15 @@ export interface FingerprintOptions extends CopyOptions {
*/
readonly extraHash?: string;
}

/**
* Options related to calculating source hash.
*/
export interface FingerprintOptions extends CopyOptions, ExtraHashOptions {
}

/**
* Options related to calculating source hash.
*/
export interface FileFingerprintOptions extends FileCopyOptions, ExtraHashOptions {
}