feat(aws-s3): adds s3 bucket AWS FSBP option #12804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds an option to enforce ssl for s3 buckets. Closes #10969 Signed-off-by: crashGoBoom <crashGoBoom@users.noreply.github.com>
|
|
Signed-off-by: crashGoBoom <crashGoBoom@users.noreply.github.com>
iliapolo
reviewed
Feb 21, 2021
There was a problem hiding this comment.
@crashGoBoom Can you add a small section to the README about this?
Something like:
AWS Foundational Security Best Practices
....
Enforcing SSL
...
iliapolo
added
the
response-requested
Signed-off-by: crashGoBoom <crashGoBoom@users.noreply.github.com>
…into issue_10969
github-actions
bot
removed
the
response-requested
iliapolo
approved these changes
Feb 23, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
Merged
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an option to enforce ssl for s3 buckets.
Closes #10969
Signed-off-by: crashGoBoom crashGoBoom@users.noreply.github.com
Replaces the PR #10970 as it was created with an ORG fork which is not compatible with the required option "Allow edits by maintainers".
FYI @NetaNir
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license