Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(aws-ecs-patterns): allow ScheduledTaskBase be created in a DISABLED state #12837

Merged
merged 5 commits into from
Feb 15, 2021
Merged

feat(aws-ecs-patterns): allow ScheduledTaskBase be created in a DISABLED state #12837

merged 5 commits into from
Feb 15, 2021

Conversation

ScottWalkerAU
Copy link
Contributor

fixes #12836

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 3, 2021 •
edited
Loading

SoManyHs
SoManyHs previously approved these changes Feb 15, 2021
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@mergify mergify bot dismissed SoManyHs’s stale review February 15, 2021 21:22

Pull request has been modified.

@SoManyHs
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2021

Command update: success

Branch already up to date

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 09ce5b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 15, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c625699 into aws:master Feb 15, 2021
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this pull request Feb 18, 2021
@ScottWalkerAU @NovakGu
feat(aws-ecs-patterns): allow ScheduledTaskBase be created in a DISAB…
481d7b0 
…LED state (aws#12837)

fixes aws#12836

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this pull request Feb 22, 2021
@ScottWalkerAU
feat(aws-ecs-patterns): allow ScheduledTaskBase be created in a DISAB…
a08b048 
…LED state (#12837)

fixes #12836

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-ecs-patterns): allow ScheduledTaskBase be created in a DISABLED state
3 participants
@ScottWalkerAU @SoManyHs @aws-cdk-automation