Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): custom resource provider NODEJS_12 now looks like Lambda's NODEJS_12_X, add Node 14 #13301

Merged
merged 5 commits into from
Mar 3, 2021
Merged

fix(core): custom resource provider NODEJS_12 now looks like Lambda's NODEJS_12_X, add Node 14 #13301

merged 5 commits into from
Mar 3, 2021

Conversation

robertd
Copy link
Contributor

@robertd robertd commented Feb 26, 2021

Purpose of this PR is to align runtime options for custom resource providers with aws-lambda runtime options.

New selections include NODEJS_12_X and NODE_JS_14_X.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Feb 26, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/core Related to core CDK functionality label Feb 26, 2021
@robertd robertd changed the title chore(core): deprecate NODEJS_12 for custom resource provider and add NODEJS_12_X and NODE_JS_14_X options chore(core): deprecate NODEJS_12 option for custom resource provider and add NODEJS_12_X and NODE_JS_14_X options Feb 26, 2021
@robertd robertd changed the title chore(core): deprecate NODEJS_12 option for custom resource provider and add NODEJS_12_X and NODE_JS_14_X options fix(core): deprecate NODEJS_12 option for custom resource provider and add NODEJS_12_X and NODE_JS_14_X options Feb 26, 2021
@robertd
Copy link
Contributor Author

robertd commented Mar 2, 2021

@rix0rrr Please review. Thanks!

@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr changed the title fix(core): deprecate NODEJS_12 option for custom resource provider and add NODEJS_12_X and NODE_JS_14_X options fix(core): custom resource provider NODEJS_12 now looks like Lambda's NODEJS_12_X, add Node 14 Mar 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Mar 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 3, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 805ce45
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3413b2f into aws:master Mar 3, 2021
@robertd robertd deleted the core-cleanup-runtime-options branch March 3, 2021 18:34
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
@robertd @cornerwings
fix(core): custom resource provider NODEJS_12 now looks like Lambda's…
d2e5f10 
… NODEJS_12_X, add Node 14 (aws#13301)

Purpose of this PR is to align `runtime` options for custom resource providers with `aws-lambda` runtime options.

New selections include `NODEJS_12_X` and `NODE_JS_14_X`.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@viniciuskneves
Copy link

Hey @robertd, Lambda Edge doesn't support Node 14 yet, right?

Docs are here: https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/lambda-requirements-limits.html#lambda-requirements-lambda-function-configuration

I tried it myself and got an error message when deploying.

@robertd
Copy link
Contributor Author

robertd commented Mar 11, 2021 •
edited
Loading

@viniciuskneves You're correct... Lambda@Edge doesn't but (according to docs) custom resource lambda does (inline version).

image

image

@nija-at @rix0rrr @njlynch Any thoughts on how to handle this catch 22?

Should we revert custom resource to use Node 12 only? Or should we put checks in place for Lambda@Edge since it's experimental feature at the moment?

@robertd robertd mentioned this pull request Mar 11, 2021
Closed
1 task
@nija-at
Copy link
Contributor

nija-at commented Mar 16, 2021

@viniciuskneves & @robertd - could you open an issue for this?

@nija-at
Copy link
Contributor

nija-at commented Mar 16, 2021

Oops, I see you already have - #13551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

@nija-at nija-at

Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/core Related to core CDK functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@robertd @aws-cdk-automation @viniciuskneves @nija-at @rix0rrr