Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add new interfaces for Assets #13356

Merged
merged 2 commits into from
Mar 4, 2021

Conversation

skinny85
Copy link
Contributor

@skinny85 skinny85 commented Mar 3, 2021

This is a re-submit of the PR #12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version 1.23.0,
which is what we currently use,
re-introduce the changes from that PR.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

This is a re-submit of the PR aws#12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version `1.23.0`,
which is what we currently use,
re-introduce the changes from that PR.
@skinny85 skinny85 requested a review from nija-at March 3, 2021 00:31
@gitpod-io
Copy link

gitpod-io bot commented Mar 3, 2021

@github-actions github-actions bot added the @aws-cdk/assets Related to the @aws-cdk/assets package label Mar 3, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 3, 2021
@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 96b4be3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 4, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 48963f7 into aws:master Mar 4, 2021
@skinny85 skinny85 deleted the chore/replace-old-copy-options branch March 4, 2021 22:01
nija-at pushed a commit that referenced this pull request Mar 5, 2021
This is a re-submit of the PR #12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version `1.23.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Mar 5, 2021
mergify bot pushed a commit that referenced this pull request Mar 5, 2021
This reverts commit 48963f7

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
nija-at pushed a commit that referenced this pull request Mar 8, 2021
This is a re-submit of the PR #12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version `1.23.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
This is a re-submit of the PR aws#12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version `1.23.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
This reverts commit 48963f7

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
nija-at pushed a commit that referenced this pull request Mar 9, 2021
This is a re-submit of the PR #12700,
which had to be reverted because of JSII issue aws/jsii#2256.
Since that issue has been fixed in JSII version `1.23.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
njlynch pushed a commit that referenced this pull request Mar 22, 2021
This reverts commit 48963f7

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
skinny85 added a commit to skinny85/aws-cdk that referenced this pull request Mar 25, 2021
This is a re-submit of the PR aws#13356,
which had to be reverted because of JSII issue aws/jsii#2653.
Since that issue has been fixed in JSII version `1.26.0`,
which is what we currently use,
re-introduce the changes from that PR.
mergify bot pushed a commit that referenced this pull request Mar 29, 2021
This is a re-submit of the PR #13356,
which had to be reverted because of JSII issue aws/jsii#2653.
Since that issue has been fixed in JSII version `1.26.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
This is a re-submit of the PR aws#13356,
which had to be reverted because of JSII issue aws/jsii#2653.
Since that issue has been fixed in JSII version `1.26.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
This is a re-submit of the PR aws#13356,
which had to be reverted because of JSII issue aws/jsii#2653.
Since that issue has been fixed in JSII version `1.26.0`,
which is what we currently use,
re-introduce the changes from that PR.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants