fix(stepfunctions): no validation on state machine name #13387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
@aws-cdk/aws-stepfunctions
shivlaks
previously requested changes
Mar 4, 2021
There was a problem hiding this comment.
@jonnekaunisto thanks for submitting a fix for this! I've left a couple of minor suggestions.
shivlaks
changed the title
shivlaks
changed the title
shivlaks
reviewed
Mar 5, 2021
There was a problem hiding this comment.
@jonnekaunisto looks great! one minor test case to add and we're good to go here.
thanks for turning it around so quickly!!
Comment on lines
+81
to
+83
| expect(() => { | ||
| createStateMachine(tooLongName); | ||
| }).toThrow(`State Machine name must be between 1 and 80 characters. Received: ${tooLongName}`); |
There was a problem hiding this comment.
let's also add one more expect for a blank string to cover the other side of the bounds.
shivlaks
previously requested changes
Mar 5, 2021
shivlaks
approved these changes
Mar 9, 2021
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This was referenced Mar 12, 2021
This was referenced Mar 15, 2021
Merged
Merged
Merged
Closed
Closed
This was referenced Mar 16, 2021
jstrese
added a commit
to jstrese/aws-cdk
that referenced
this pull request
Apr 3, 2021
Name validation for state machines was added in aws#13387. The validation did not take into consideration that the name may contain an unresolved token. This change skips name validation if there is an unresolved token as it does not make sense to attempt to validate something that is unknown. This change also allows a few more special characters as they are allowed through the AWS Console. fixes aws#13946
mergify bot
pushed a commit
that referenced
this pull request
Apr 8, 2021
…re used. (#13970) Name validation for state machines was added in #13387. The validation added was not considering that the name may contain an unresolved token. This change skips name validation if there is an unresolved token as it does not make sense to attempt to validate something that is unknown. This change also allows a few more special characters as they are allowed through the AWS Console. fixes #13946 #13912 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this pull request
Aug 26, 2021
…re used. (aws#13970) Name validation for state machines was added in aws#13387. The validation added was not considering that the name may contain an unresolved token. This change skips name validation if there is an unresolved token as it does not make sense to attempt to validate something that is unknown. This change also allows a few more special characters as they are allowed through the AWS Console. fixes aws#13946 aws#13912 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #13289
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license